From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxDiM-0001sC-Ol for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxDiJ-0005O3-Ln for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:48:58 -0400 References: <1476957133-24382-1-git-send-email-anand.indukala@gmail.com> From: Eric Blake Message-ID: Date: Thu, 20 Oct 2016 08:48:53 -0500 MIME-Version: 1.0 In-Reply-To: <1476957133-24382-1-git-send-email-anand.indukala@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jTEH83tImJRlERaQnf5eEsn49DwqtXuoU" Subject: Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anand J , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, thuth@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jTEH83tImJRlERaQnf5eEsn49DwqtXuoU From: Eric Blake To: Anand J , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, thuth@redhat.com Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check References: <1476957133-24382-1-git-send-email-anand.indukala@gmail.com> In-Reply-To: <1476957133-24382-1-git-send-email-anand.indukala@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [meta-comment] On 10/20/2016 04:52 AM, Anand J wrote: > Added script to check duplicate #include entries. This check will scan > and print the files in which duplicate #include entries are present. This appears to be a v2 patch. But it is missing a 0/2 cover letter, and mention of v2 in the subject line. 'git format-patch --cover-letter -v2' will do what you want (as well as git send-email, which understands all options accepted by format-patch); it's also possible to automate git to send a cover letter any time you send more than one patch by using 'git config format.coverLetter auto'. More patch submission tips at http://wiki.qemu.org/Contribute/SubmitAPatc= h >=20 > Script might output false positive entries as well. Such entries should= > not be removed. So if it finds any duplicate entries script will > terminate with an exit status 1. Then each and every file should be > checked manually and corrected if necessary. >=20 > In order to enable the check use --check-duphead option with > script/clean-includes. >=20 > Reviewed-by: Thomas Huth > Signed-off-by: Anand J > --- > scripts/clean-includes | 50 +++++++++++++++++++++++++++++++++++++-----= -------- > 1 file changed, 37 insertions(+), 13 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jTEH83tImJRlERaQnf5eEsn49DwqtXuoU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYCMtFAAoJEKeha0olJ0NqK8MH/2xqaClqb9/zr78o2LS8zqvk +uqj7yPsGtN/ufm6rY7s+RCE3DhKdSn1Eyqt/INzD6ulnAuYCNXBYlRtOEYKnRlx PaH4ateDPKMgXIr1noJoGlBy/mzUypXs9P1G+Y8X8mZhHWuuNjev+8AFfi2yNuY/ 31kzP45HcsyChdF3iwaMglJbKDBMtHN3kIG4t8iIRlFSp++jYT6B0UiJTb2wwSvi cu2GHzgh9RFdmDdTAxdAkGwEVcVILPpPqWoukyldFp+drX5J3tqvGCCKgpb1rzsb u1BIrrRssN9vWbEKWkQ2Vn8AwWmR/UsFI2KJ3JMJFrcglemuR6xcQFJG6duWEw0= =lSUU -----END PGP SIGNATURE----- --jTEH83tImJRlERaQnf5eEsn49DwqtXuoU--