From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dijPL-0007VO-Iz for qemu-devel@nongnu.org; Fri, 18 Aug 2017 11:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dijPI-0004bD-F2 for qemu-devel@nongnu.org; Fri, 18 Aug 2017 11:41:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49838) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dijPI-0004b4-8a for qemu-devel@nongnu.org; Fri, 18 Aug 2017 11:41:56 -0400 References: <20170818114353.13455-1-david@redhat.com> <20170818114353.13455-6-david@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 18 Aug 2017 17:41:51 +0200 MIME-Version: 1.0 In-Reply-To: <20170818114353.13455-6-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: rth@twiddle.net, Aurelien Jarno , cohuck@redhat.com, borntraeger@de.ibm.com, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 18.08.2017 13:43, David Hildenbrand wrote: > Let's avoid any KVM stuff in s390-virtio-ccw.c. This parameter is simply > ignored. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 3e9b455..f19fab5 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -161,7 +161,7 @@ static void ccw_init(MachineState *machine) > s390_create_virtio_net(BUS(css_bus), "virtio-net-ccw"); > > /* Register savevm handler for guest TOD clock */ > - register_savevm_live(NULL, "todclock", 0, 1, &savevm_gtod, kvm_state); > + register_savevm_live(NULL, "todclock", 0, 1, &savevm_gtod, NULL); > } > Reviewed-by: Thomas Huth