From: Thomas Huth <thuth@redhat.com>
To: Peter Krempa <pkrempa@redhat.com>
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
qemu-devel@nongnu.org, devel@lists.libvirt.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-ppc@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules
Date: Wed, 17 Jan 2024 15:05:07 +0100 [thread overview]
Message-ID: <e7d4b93a-d5d4-44f3-8317-eaa81c3b8653@redhat.com> (raw)
In-Reply-To: <ZaE1NOjbFeWyxIeQ@angien.pipo.sk>
On 12/01/2024 13.48, Peter Krempa wrote:
> On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote:
>> We can get rid of the "power5+" / "power7+" hack in qom/object.c
>> by using CPU aliases for those names instead (first patch).
>>
>> I think in the long run, we should get rid of the names with a "+"
>> in it completely, so the second patch suggests to deprecate those,
>> but I'd also be fine if we keep the aliases around, so in that case
>> please ignore the second patch.
>>
>> Thomas Huth (2):
>> target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming
>> rules
>> docs/about: Deprecate the old "power5+" and "power7+" CPU names
>
> libvirt seems to be explicitly referencing power7+ in the code, so I
> guess we'll need code to translate the + versions to the spellt-out
> version to preserve compatibility.
If it's too cumbersome, we could also keep the alias enabled in QEMU, i.e.
drop the second patch...?
Thomas
prev parent reply other threads:[~2024-01-17 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:46 [PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules Thomas Huth
2024-01-11 16:46 ` [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for " Thomas Huth
2024-01-11 17:24 ` Cédric Le Goater
2024-01-12 4:57 ` Harsh Prateek Bora
2024-01-12 5:12 ` Thomas Huth
2024-01-12 5:21 ` Harsh Prateek Bora
2024-01-12 10:55 ` Thomas Huth
2024-01-12 11:33 ` Cédric Le Goater
2024-01-12 15:47 ` Philippe Mathieu-Daudé
2024-01-11 16:46 ` [PATCH 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names Thomas Huth
2024-01-11 17:25 ` Cédric Le Goater
2024-01-12 12:48 ` [PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules Peter Krempa
2024-01-17 14:05 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d4b93a-d5d4-44f3-8317-eaa81c3b8653@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=devel@lists.libvirt.org \
--cc=eduardo@habkost.net \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).