From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled
Date: Thu, 11 May 2017 09:48:52 +0200 [thread overview]
Message-ID: <e7dca113-22b8-1917-d759-3c4e42271e0f@redhat.com> (raw)
In-Reply-To: <20170511025649.GC28293@pxdev.xzpeter.org>
On 11/05/2017 04:56, Peter Xu wrote:
>> @@ -3510,12 +3511,16 @@ static void kvm_update_msi_routes_all(void *private, bool global,
>> int cnt = 0;
>> MSIRouteEntry *entry;
>> MSIMessage msg;
>> + PCIDevice *dev;
>> +
>> /* TODO: explicit route update */
>> QLIST_FOREACH(entry, &msi_route_list, list) {
>> - cnt++;
>
> Oops, I think this line should be kept. It does not affect too much,
> only the trace below. But still, no reason to remove it.
>
> Paolo, would it still possible to touch it up in your queue?
Yup, fixed.
Paolo
next prev parent reply other threads:[~2017-05-11 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 6:00 [Qemu-devel] [PATCH v2 0/3] kvm: irqchip: skip msi update when msi disabled Peter Xu
2017-05-09 6:00 ` [Qemu-devel] [PATCH v2 1/3] kvm: irqchip: trace changes on msi add/remove Peter Xu
2017-05-10 10:45 ` Philippe Mathieu-Daudé
2017-05-09 6:00 ` [Qemu-devel] [PATCH v2 2/3] msix: trace control bit write op Peter Xu
2017-05-10 10:44 ` Philippe Mathieu-Daudé
2017-05-10 18:30 ` Michael S. Tsirkin
2017-05-10 18:30 ` Michael S. Tsirkin
2017-05-09 6:00 ` [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled Peter Xu
2017-05-11 2:56 ` Peter Xu
2017-05-11 7:48 ` Paolo Bonzini [this message]
2017-05-11 7:54 ` Peter Xu
2017-05-10 15:32 ` [Qemu-devel] [PATCH v2 0/3] kvm: irqchip: skip msi update when msi disabled Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7dca113-22b8-1917-d759-3c4e42271e0f@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).