From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Chrysostomos Nanakos <chris@include.gr>
Subject: Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile
Date: Wed, 8 Mar 2017 12:25:04 -0600 [thread overview]
Message-ID: <e7e616d7-441f-9cff-d182-cbda19700ec5@redhat.com> (raw)
In-Reply-To: <20170308181833.32110-1-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On 03/08/2017 12:18 PM, Max Reitz wrote:
> In order to use error_setg() and similar functions, we need to include
> qapi/error.h.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/archipelago.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
Does this mean our automated buildbots aren't building archipelago by
default?
>
> diff --git a/block/archipelago.c b/block/archipelago.c
> index 2449cfc702..01c4ff2f7d 100644
> --- a/block/archipelago.c
> +++ b/block/archipelago.c
> @@ -55,6 +55,7 @@
> #include "block/block_int.h"
> #include "qemu/error-report.h"
> #include "qemu/thread.h"
> +#include "qapi/error.h"
> #include "qapi/qmp/qint.h"
> #include "qapi/qmp/qstring.h"
> #include "qapi/qmp/qjson.h"
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-08 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 18:18 [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile Max Reitz
2017-03-08 18:25 ` Eric Blake [this message]
2017-03-08 18:27 ` Max Reitz
2017-03-08 18:28 ` Eric Blake
2017-03-08 18:32 ` Max Reitz
2017-03-08 18:46 ` Kevin Wolf
2017-03-08 19:33 ` Eric Blake
2017-03-08 18:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7e616d7-441f-9cff-d182-cbda19700ec5@redhat.com \
--to=eblake@redhat.com \
--cc=chris@include.gr \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).