From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673A7C433FE for ; Wed, 3 Nov 2021 09:20:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FE4261156 for ; Wed, 3 Nov 2021 09:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0FE4261156 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miCRo-0008Tj-0N for qemu-devel@archiver.kernel.org; Wed, 03 Nov 2021 05:20:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miCQj-0007Zt-30 for qemu-devel@nongnu.org; Wed, 03 Nov 2021 05:19:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miCQg-00072s-Ok for qemu-devel@nongnu.org; Wed, 03 Nov 2021 05:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635931173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlSJMTrIlMoMpUC+EgVS2nJKoLZpUzPS8qGCSqmT4Kk=; b=bDW/tDCXcXAQDeZHT4srxXIV79LD3KLAcrknD8oqBrG+wZZBR4LT/L7rQ63P4oJddVYrx2 VfOvBMKyPHlBl6y5NkguFdOfs5O7YjbNSNrlxsB29ykdBtKE0qMeDFjRNFwK7qFWp5MsOv bIAyQ+5VXffNsBUepIv1pcGSqjyhwRA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-sr9LzTEoPByHjIRR2wyugQ-1; Wed, 03 Nov 2021 05:19:30 -0400 X-MC-Unique: sr9LzTEoPByHjIRR2wyugQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74AE45074B; Wed, 3 Nov 2021 09:19:29 +0000 (UTC) Received: from [10.39.192.84] (unknown [10.39.192.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 224A457CD2; Wed, 3 Nov 2021 09:19:26 +0000 (UTC) Message-ID: Date: Wed, 3 Nov 2021 10:19:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: does drive_get_next(IF_NONE) make sense? To: Markus Armbruster , Peter Maydell References: <87r1bxzl5c.fsf@dusky.pond.sub.org> From: Thomas Huth In-Reply-To: <87r1bxzl5c.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -60 X-Spam_score: -6.1 X-Spam_bar: ------ X-Spam_report: (-6.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.549, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hao Wu , Bin Meng , Alistair Francis , QEMU Developers , Qemu-block Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/11/2021 09.41, Markus Armbruster wrote: > Peter Maydell writes: > >> Does it make sense for a device/board to do drive_get_next(IF_NONE) ? > > Short answer: hell, no! ;) Would it make sense to add an "assert(type != IF_NONE)" to drive_get() to avoid such mistakes in the future? Thomas