From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D31CC636CC for ; Tue, 14 Feb 2023 01:48:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRkQB-0008VU-PT; Mon, 13 Feb 2023 20:47:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRkQA-0008VG-5W for qemu-devel@nongnu.org; Mon, 13 Feb 2023 20:47:50 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRkQ7-0000X9-DX for qemu-devel@nongnu.org; Mon, 13 Feb 2023 20:47:49 -0500 Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PG3tr1plsz16NcK; Tue, 14 Feb 2023 09:45:24 +0800 (CST) Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Tue, 14 Feb 2023 09:46:51 +0800 Message-ID: Date: Tue, 14 Feb 2023 09:46:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC 42/52] hw/machine: Add hybrid_supported in generic topo properties To: Zhao Liu , Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S . Tsirkin" , Richard Henderson , Paolo Bonzini , Eric Blake , Markus Armbruster CC: , Zhenyu Wang , Dapeng Mi , Zhuocheng Ding , Robert Hoo , Sean Christopherson , Like Xu , Zhao Liu References: <20230213095035.158240-1-zhao1.liu@linux.intel.com> <20230213095035.158240-43-zhao1.liu@linux.intel.com> In-Reply-To: <20230213095035.158240-43-zhao1.liu@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.255; envelope-from=wangyanan55@huawei.com; helo=szxga08-in.huawei.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.345, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "wangyanan (Y)" From: "wangyanan (Y)" via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Zhao, 在 2023/2/13 17:50, Zhao Liu 写道: > From: Zhao Liu > > Since hybrid cpu topology configuration can benefit not only x86, but > also other architectures/platforms that have supported (in real > machines) or will support hybrid CPU topology, "-hybrid" can be generic. > > So add the generic topology property to configure if support hybrid > cpu topology for architectures/platforms in SmpCompatProps. > > Also rename SmpCompatProps to TopoCompatProps to make this structure > more generic for both smp topology and hybrid topology. > > Signed-off-by: Zhao Liu > --- > include/hw/boards.h | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 34ec035b5c9f..17be3485e823 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -127,19 +127,26 @@ typedef struct { > } CPUArchIdList; > > /** > - * SMPCompatProps: > - * @prefer_sockets - whether sockets are preferred over cores in smp parsing > + * TopoCompatProps: > + * @hybrid_support - whether hybrid cpu topology are supported by machine. inconsistent with the name in the definition below. > + * Note that hybrid cpu topology requires to specify the > + * topology of each core so that there will no longer be > + * a default core topology, thus prefer_sockets won't work > + * when hybrid_support is enabled. > + * @prefer_sockets - whether sockets are preferred over cores in smp parsing. > + * Not work when hybrid_support is enabled. > * @dies_supported - whether dies are supported by the machine > * @clusters_supported - whether clusters are supported by the machine > * @has_clusters - whether clusters are explicitly specified in the user > * provided SMP configuration > */ > typedef struct { > + bool hybrid_supported; > bool prefer_sockets; > bool dies_supported; > bool clusters_supported; > bool has_clusters; > -} SMPCompatProps; > +} TopoCompatProps; > Also here. "Rename SMPCompatProps to TopoCompatProps and move it to cpu-topology.h and adapt the code" should be organized in one or more separate patches, being pre-patches together with the conversion of CpuTopology before. And put the "hybrid_supported" extension into another patch. Would this make it easier to review? Thanks, Yanan > /** > * MachineClass: > @@ -281,7 +288,7 @@ struct MachineClass { > bool nvdimm_supported; > bool numa_mem_supported; > bool auto_enable_numa; > - SMPCompatProps smp_props; > + TopoCompatProps smp_props; > const char *default_ram_id; > > HotplugHandler *(*get_hotplug_handler)(MachineState *machine,