From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 8/8] spapr/drc: Clean up local variable shadowing in prop_get_fdt()
Date: Mon, 18 Sep 2023 17:30:40 +0200 [thread overview]
Message-ID: <e81b785e-495b-609f-12e8-f2bd973b6f24@linaro.org> (raw)
In-Reply-To: <20230918145850.241074-9-clg@kaod.org>
On 18/9/23 16:58, Cédric Le Goater wrote:
> Rename 'name' variable to avoid this warning :
>
> ../hw/ppc/spapr_drc.c: In function ‘prop_get_fdt’:
> ../hw/ppc/spapr_drc.c:344:21: warning: declaration of ‘name’ shadows a parameter [-Wshadow=compatible-local]
> 344 | const char *name = NULL;
> | ^~~~
> ../hw/ppc/spapr_drc.c:325:63: note: shadowed declaration is here
> 325 | static void prop_get_fdt(Object *obj, Visitor *v, const char *name,
> | ~~~~~~~~~~~~^~~~
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/spapr_drc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-09-18 15:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 14:58 [PATCH 0/8] ppc: Clean up local variable shadowing Cédric Le Goater
2023-09-18 14:58 ` [PATCH 1/8] hw/ppc: Clean up local variable shadowing in _FDT helper routine Cédric Le Goater
2023-09-19 6:53 ` Harsh Prateek Bora
2023-09-18 14:58 ` [PATCH 2/8] pnv/psi: Clean up local variable shadowing Cédric Le Goater
2023-09-19 6:57 ` Harsh Prateek Bora
2023-09-19 9:03 ` Cédric Le Goater
2023-09-29 5:30 ` Markus Armbruster
2023-09-29 6:13 ` Cédric Le Goater
2023-09-18 14:58 ` [PATCH 3/8] spapr: Clean up local variable shadowing in spapr_dt_cpus() Cédric Le Goater
2023-09-19 7:28 ` Harsh Prateek Bora
2023-09-19 11:05 ` Cédric Le Goater
2023-09-19 13:04 ` Harsh Prateek Bora
2023-09-19 14:59 ` Harsh Prateek Bora
2023-09-19 15:05 ` Cédric Le Goater
2023-09-18 14:58 ` [PATCH 4/8] spapr: Clean up local variable shadowing in spapr_init_cpus() Cédric Le Goater
2023-09-19 7:30 ` Harsh Prateek Bora
2023-09-18 14:58 ` [PATCH 5/8] spapr: Clean up local variable shadowing in spapr_get_fw_dev_path() Cédric Le Goater
2023-09-18 15:29 ` Philippe Mathieu-Daudé
2023-09-19 8:23 ` Harsh Prateek Bora
2023-09-19 11:54 ` Cédric Le Goater
2023-09-18 14:58 ` [PATCH 6/8] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector() Cédric Le Goater
2023-09-19 8:29 ` Harsh Prateek Bora
2023-09-19 12:02 ` Cédric Le Goater
2023-09-19 13:01 ` Harsh Prateek Bora
2023-09-29 5:34 ` Markus Armbruster
2023-09-29 5:43 ` Harsh Prateek Bora
2023-09-18 14:58 ` [PATCH 7/8] spapr/pci: Clean up local variable shadowing in spapr_phb_realize() Cédric Le Goater
2023-09-19 8:38 ` Harsh Prateek Bora
2023-09-19 12:04 ` Cédric Le Goater
2023-09-18 14:58 ` [PATCH 8/8] spapr/drc: Clean up local variable shadowing in prop_get_fdt() Cédric Le Goater
2023-09-18 15:30 ` Philippe Mathieu-Daudé [this message]
2023-09-19 8:48 ` Harsh Prateek Bora
2023-09-19 12:07 ` Cédric Le Goater
2023-09-19 12:55 ` Harsh Prateek Bora
2023-09-29 5:39 ` Markus Armbruster
2023-09-29 6:07 ` Cédric Le Goater
2023-09-29 6:18 ` Harsh Prateek Bora
2023-10-04 10:26 ` [PATCH 0/8] ppc: Clean up local variable shadowing Markus Armbruster
2023-10-04 11:56 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e81b785e-495b-609f-12e8-f2bd973b6f24@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).