[PATCH 00/11] target/hppa patch queue

[PATCH 00/11] target/hppa patch queue

[Richard Henderson]

Version 4 fixes trivial conflicts with 

commit 4f67d30b5e74e060b8dbe10528829b47345cd6e8
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Fri Jan 10 19:30:32 2020 +0400

    qdev: set properties with device_class_set_props()


r~


The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +0000)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-pa-20200127

for you to fetch changes up to b1af755c33bf0d690553a5ccd93689dfd15a98e8:

  target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-27 10:49:51 -0800)

----------------------------------------------------------------
Improve LASI emulation
Add Artist graphics
Fix main memory allocation
Improve LDCW emulation wrt real hw

----------------------------------------------------------------
Helge Deller (3):
      hw/hppa/dino.c: Improve emulation of Dino PCI chip
      hppa: Add support for LASI chip with i82596 NIC
      hppa: Switch to tulip NIC by default

Philippe Mathieu-Daudé (3):
      hw/hppa/machine: Correctly check the firmware is in PDC range
      hw/hppa/machine: Restrict the total memory size to 3GB
      hw/hppa/machine: Map the PDC memory region with higher priority

Richard Henderson (1):
      target/hppa: Allow, but diagnose, LDCW aligned only mod 4

Sven Schnelle (4):
      ps2: accept 'Set Key Make and Break' commands
      hppa: add emulation of LASI PS2 controllers
      seabios-hppa: update to latest version
      hppa: Add emulation of Artist graphics

 hw/hppa/hppa_hardware.h        |    1 +
 hw/hppa/hppa_sys.h             |    2 +
 hw/net/i82596.h                |   55 ++
 include/hw/input/lasips2.h     |   16 +
 include/hw/input/ps2.h         |    1 +
 include/hw/net/lasi_82596.h    |   29 +
 target/hppa/helper.h           |    2 +
 hw/display/artist.c            | 1454 ++++++++++++++++++++++++++++++++++++++++
 hw/hppa/dino.c                 |   97 ++-
 hw/hppa/lasi.c                 |  368 ++++++++++
 hw/hppa/machine.c              |   33 +-
 hw/input/lasips2.c             |  291 ++++++++
 hw/input/ps2.c                 |   15 +
 hw/net/i82596.c                |  734 ++++++++++++++++++++
 hw/net/lasi_i82596.c           |  188 ++++++
 target/hppa/op_helper.c        |    9 +
 target/hppa/translate.c        |   15 +-
 tests/qtest/boot-serial-test.c |    3 +-
 MAINTAINERS                    |    4 +-
 hw/display/Kconfig             |    4 +
 hw/display/Makefile.objs       |    1 +
 hw/display/trace-events        |    9 +
 hw/hppa/Kconfig                |    3 +
 hw/hppa/Makefile.objs          |    2 +-
 hw/hppa/trace-events           |   10 +
 hw/input/Kconfig               |    3 +
 hw/input/Makefile.objs         |    1 +
 hw/input/trace-events          |    5 +
 hw/net/Kconfig                 |    7 +
 hw/net/Makefile.objs           |    2 +
 hw/net/trace-events            |   13 +
 pc-bios/hppa-firmware.img      |  Bin 783724 -> 766136 bytes
 roms/seabios-hppa              |    2 +-
 33 files changed, 3351 insertions(+), 28 deletions(-)
 create mode 100644 hw/net/i82596.h
 create mode 100644 include/hw/input/lasips2.h
 create mode 100644 include/hw/net/lasi_82596.h
 create mode 100644 hw/display/artist.c
 create mode 100644 hw/hppa/lasi.c
 create mode 100644 hw/input/lasips2.c
 create mode 100644 hw/net/i82596.c
 create mode 100644 hw/net/lasi_i82596.c

Re: [PULL 00/11] target/hppa patch queue

[Richard Henderson]

On 1/27/20 11:01 AM, Richard Henderson wrote:
> Version 4 fixes trivial conflicts with 
> 
> commit 4f67d30b5e74e060b8dbe10528829b47345cd6e8
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date:   Fri Jan 10 19:30:32 2020 +0400
> 
>     qdev: set properties with device_class_set_props()

Ho hum, missed "PULL" in the subject.


r~



> The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
> 
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +0000)
> 
> are available in the Git repository at:
> 
>   https://github.com/rth7680/qemu.git tags/pull-pa-20200127
> 
> for you to fetch changes up to b1af755c33bf0d690553a5ccd93689dfd15a98e8:
> 
>   target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-27 10:49:51 -0800)
> 
> ----------------------------------------------------------------
> Improve LASI emulation
> Add Artist graphics
> Fix main memory allocation
> Improve LDCW emulation wrt real hw
> 
> ----------------------------------------------------------------
> Helge Deller (3):
>       hw/hppa/dino.c: Improve emulation of Dino PCI chip
>       hppa: Add support for LASI chip with i82596 NIC
>       hppa: Switch to tulip NIC by default
> 
> Philippe Mathieu-Daudé (3):
>       hw/hppa/machine: Correctly check the firmware is in PDC range
>       hw/hppa/machine: Restrict the total memory size to 3GB
>       hw/hppa/machine: Map the PDC memory region with higher priority
> 
> Richard Henderson (1):
>       target/hppa: Allow, but diagnose, LDCW aligned only mod 4
> 
> Sven Schnelle (4):
>       ps2: accept 'Set Key Make and Break' commands
>       hppa: add emulation of LASI PS2 controllers
>       seabios-hppa: update to latest version
>       hppa: Add emulation of Artist graphics
> 
>  hw/hppa/hppa_hardware.h        |    1 +
>  hw/hppa/hppa_sys.h             |    2 +
>  hw/net/i82596.h                |   55 ++
>  include/hw/input/lasips2.h     |   16 +
>  include/hw/input/ps2.h         |    1 +
>  include/hw/net/lasi_82596.h    |   29 +
>  target/hppa/helper.h           |    2 +
>  hw/display/artist.c            | 1454 ++++++++++++++++++++++++++++++++++++++++
>  hw/hppa/dino.c                 |   97 ++-
>  hw/hppa/lasi.c                 |  368 ++++++++++
>  hw/hppa/machine.c              |   33 +-
>  hw/input/lasips2.c             |  291 ++++++++
>  hw/input/ps2.c                 |   15 +
>  hw/net/i82596.c                |  734 ++++++++++++++++++++
>  hw/net/lasi_i82596.c           |  188 ++++++
>  target/hppa/op_helper.c        |    9 +
>  target/hppa/translate.c        |   15 +-
>  tests/qtest/boot-serial-test.c |    3 +-
>  MAINTAINERS                    |    4 +-
>  hw/display/Kconfig             |    4 +
>  hw/display/Makefile.objs       |    1 +
>  hw/display/trace-events        |    9 +
>  hw/hppa/Kconfig                |    3 +
>  hw/hppa/Makefile.objs          |    2 +-
>  hw/hppa/trace-events           |   10 +
>  hw/input/Kconfig               |    3 +
>  hw/input/Makefile.objs         |    1 +
>  hw/input/trace-events          |    5 +
>  hw/net/Kconfig                 |    7 +
>  hw/net/Makefile.objs           |    2 +
>  hw/net/trace-events            |   13 +
>  pc-bios/hppa-firmware.img      |  Bin 783724 -> 766136 bytes
>  roms/seabios-hppa              |    2 +-
>  33 files changed, 3351 insertions(+), 28 deletions(-)
>  create mode 100644 hw/net/i82596.h
>  create mode 100644 include/hw/input/lasips2.h
>  create mode 100644 include/hw/net/lasi_82596.h
>  create mode 100644 hw/display/artist.c
>  create mode 100644 hw/hppa/lasi.c
>  create mode 100644 hw/input/lasips2.c
>  create mode 100644 hw/net/i82596.c
>  create mode 100644 hw/net/lasi_i82596.c
> 

Re: [PATCH 00/11] target/hppa patch queue

[Peter Maydell]

On Mon, 27 Jan 2020 at 19:01, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Version 4 fixes trivial conflicts with
>
> commit 4f67d30b5e74e060b8dbe10528829b47345cd6e8
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date:   Fri Jan 10 19:30:32 2020 +0400
>
>     qdev: set properties with device_class_set_props()
>
>
> r~
>
>
> The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-pa-20200127
>
> for you to fetch changes up to b1af755c33bf0d690553a5ccd93689dfd15a98e8:
>
>   target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-27 10:49:51 -0800)
>
> ----------------------------------------------------------------
> Improve LASI emulation
> Add Artist graphics
> Fix main memory allocation
> Improve LDCW emulation wrt real hw
>



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.

-- PMM

[PULL 00/11] target/hppa patch queue

[Richard Henderson]

The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-pa-20200121

for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:

  target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)

----------------------------------------------------------------
Improve LASI emulation
Add Artist graphics
Fix main memory allocation
Improve LDCW emulation wrt real hw

----------------------------------------------------------------
Helge Deller (3):
      hw/hppa/dino.c: Improve emulation of Dino PCI chip
      hppa: Add support for LASI chip with i82596 NIC
      hppa: Switch to tulip NIC by default

Philippe Mathieu-Daudé (3):
      hw/hppa/machine: Correctly check the firmware is in PDC range
      hw/hppa/machine: Restrict the total memory size to 3GB
      hw/hppa/machine: Map the PDC memory region with higher priority

Richard Henderson (1):
      target/hppa: Allow, but diagnose, LDCW aligned only mod 4

Sven Schnelle (4):
      ps2: accept 'Set Key Make and Break' commands
      hppa: add emulation of LASI PS2 controllers
      seabios-hppa: update to latest version
      hppa: Add emulation of Artist graphics

 hw/hppa/hppa_hardware.h     |    1 +
 hw/hppa/hppa_sys.h          |    2 +
 hw/net/i82596.h             |   55 ++
 include/hw/input/lasips2.h  |   16 +
 include/hw/input/ps2.h      |    1 +
 include/hw/net/lasi_82596.h |   29 +
 target/hppa/helper.h        |    2 +
 hw/display/artist.c         | 1450 +++++++++++++++++++++++++++++++++++++++++++
 hw/hppa/dino.c              |   97 ++-
 hw/hppa/lasi.c              |  368 +++++++++++
 hw/hppa/machine.c           |   33 +-
 hw/input/lasips2.c          |  289 +++++++++
 hw/input/ps2.c              |   15 +
 hw/net/i82596.c             |  734 ++++++++++++++++++++++
 hw/net/lasi_i82596.c        |  188 ++++++
 target/hppa/op_helper.c     |    9 +
 target/hppa/translate.c     |   15 +-
 MAINTAINERS                 |    4 +-
 hw/display/Kconfig          |    4 +
 hw/display/Makefile.objs    |    1 +
 hw/display/trace-events     |    9 +
 hw/hppa/Kconfig             |    3 +
 hw/hppa/Makefile.objs       |    2 +-
 hw/hppa/trace-events        |   10 +
 hw/input/Kconfig            |    3 +
 hw/input/Makefile.objs      |    1 +
 hw/input/trace-events       |    5 +
 hw/net/Kconfig              |    7 +
 hw/net/Makefile.objs        |    2 +
 hw/net/trace-events         |   13 +
 pc-bios/hppa-firmware.img   |  Bin 783724 -> 766136 bytes
 roms/seabios-hppa           |    2 +-
 32 files changed, 3343 insertions(+), 27 deletions(-)
 create mode 100644 hw/net/i82596.h
 create mode 100644 include/hw/input/lasips2.h
 create mode 100644 include/hw/net/lasi_82596.h
 create mode 100644 hw/display/artist.c
 create mode 100644 hw/hppa/lasi.c
 create mode 100644 hw/input/lasips2.c
 create mode 100644 hw/net/i82596.c
 create mode 100644 hw/net/lasi_i82596.c

Re: [PULL 00/11] target/hppa patch queue

[Richard Henderson]

On 1/21/20 4:32 PM, Richard Henderson wrote:
> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:
> 
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)
> 
> are available in the Git repository at:
> 
>   https://github.com/rth7680/qemu.git tags/pull-pa-20200121
> 
> for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:
> 
>   target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)
> 
> ----------------------------------------------------------------
> Improve LASI emulation
> Add Artist graphics
> Fix main memory allocation
> Improve LDCW emulation wrt real hw

Ho hum.  Cancel this.  It breaks the hppa boot-serial test.


r~

Re: [PULL 00/11] target/hppa patch queue

[Philippe Mathieu-Daudé]

On 1/22/20 3:47 AM, Richard Henderson wrote:
> On 1/21/20 4:32 PM, Richard Henderson wrote:
>> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:
>>
>>    Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/rth7680/qemu.git tags/pull-pa-20200121
>>
>> for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:
>>
>>    target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)
>>
>> ----------------------------------------------------------------
>> Improve LASI emulation
>> Add Artist graphics
>> Fix main memory allocation
>> Improve LDCW emulation wrt real hw
> 
> Ho hum.  Cancel this.  It breaks the hppa boot-serial test.

This is due to patch #7 "Add emulation of Artist graphics":

130     /* Graphics setup. */
131     if (machine->enable_graphics && vga_interface_type != VGA_NONE) {
132         dev = qdev_create(NULL, "artist");
133         qdev_init_nofail(dev);
134         s = SYS_BUS_DEVICE(dev);
135         sysbus_mmio_map(s, 0, LASI_GFX_HPA);
136         sysbus_mmio_map(s, 1, ARTIST_FB_ADDR);
137     }

The hppa boot-serial test use the default options, so the Artist chipset 
is mapped, and the firmware test/use it.

We can test like the 40p, using VGA_NONE:

-- >8 --
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index 05c7f44457..971254ae62 100644
--- a/tests/qtest/boot-serial-test.c
+++ b/tests/qtest/boot-serial-test.c
@@ -135,7 +135,7 @@ static testdef_t tests[] = {
        sizeof(kernel_plml605), kernel_plml605 },
      { "moxie", "moxiesim", "", "TT", sizeof(bios_moxiesim), 0, 
bios_moxiesim },
      { "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 },
-    { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
+    { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" },
      { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
        kernel_aarch64 },
      { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
---

You should squash this change in patch #7 (because it belongs there) but 
please add a comment, because it is not obvious.

Thanks,

Phil.

Re: [PULL 00/11] target/hppa patch queue

[Philippe Mathieu-Daudé]

On Thu, Jan 23, 2020 at 12:28 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> On 1/22/20 3:47 AM, Richard Henderson wrote:
> > On 1/21/20 4:32 PM, Richard Henderson wrote:
> >> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:
> >>
> >>    Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >>    https://github.com/rth7680/qemu.git tags/pull-pa-20200121
> >>
> >> for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:
> >>
> >>    target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)
> >>
> >> ----------------------------------------------------------------
> >> Improve LASI emulation
> >> Add Artist graphics
> >> Fix main memory allocation
> >> Improve LDCW emulation wrt real hw
> >
> > Ho hum.  Cancel this.  It breaks the hppa boot-serial test.
>
> This is due to patch #7 "Add emulation of Artist graphics":
>
> 130     /* Graphics setup. */
> 131     if (machine->enable_graphics && vga_interface_type != VGA_NONE) {
> 132         dev = qdev_create(NULL, "artist");
> 133         qdev_init_nofail(dev);
> 134         s = SYS_BUS_DEVICE(dev);
> 135         sysbus_mmio_map(s, 0, LASI_GFX_HPA);
> 136         sysbus_mmio_map(s, 1, ARTIST_FB_ADDR);
> 137     }
>
> The hppa boot-serial test use the default options, so the Artist chipset
> is mapped, and the firmware test/use it.

Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Btw ;)

> We can test like the 40p, using VGA_NONE:
>
> -- >8 --
> diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
> index 05c7f44457..971254ae62 100644
> --- a/tests/qtest/boot-serial-test.c
> +++ b/tests/qtest/boot-serial-test.c
> @@ -135,7 +135,7 @@ static testdef_t tests[] = {
>         sizeof(kernel_plml605), kernel_plml605 },
>       { "moxie", "moxiesim", "", "TT", sizeof(bios_moxiesim), 0,
> bios_moxiesim },
>       { "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 },
> -    { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
> +    { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" },
>       { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
>         kernel_aarch64 },
>       { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
> ---
>
> You should squash this change in patch #7 (because it belongs there) but
> please add a comment, because it is not obvious.
>
> Thanks,
>
> Phil.

Re: [PULL 00/11] target/hppa patch queue

[Philippe Mathieu-Daudé]

On Thu, Jan 23, 2020 at 12:34 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On Thu, Jan 23, 2020 at 12:28 AM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
> >
> > On 1/22/20 3:47 AM, Richard Henderson wrote:
> > > On 1/21/20 4:32 PM, Richard Henderson wrote:
> > >> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:
> > >>
> > >>    Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >>    https://github.com/rth7680/qemu.git tags/pull-pa-20200121
> > >>
> > >> for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:
> > >>
> > >>    target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)
> > >>
> > >> ----------------------------------------------------------------
> > >> Improve LASI emulation
> > >> Add Artist graphics
> > >> Fix main memory allocation
> > >> Improve LDCW emulation wrt real hw
> > >
> > > Ho hum.  Cancel this.  It breaks the hppa boot-serial test.
> >
> > This is due to patch #7 "Add emulation of Artist graphics":
> >
> > 130     /* Graphics setup. */
> > 131     if (machine->enable_graphics && vga_interface_type != VGA_NONE) {
> > 132         dev = qdev_create(NULL, "artist");
> > 133         qdev_init_nofail(dev);
> > 134         s = SYS_BUS_DEVICE(dev);
> > 135         sysbus_mmio_map(s, 0, LASI_GFX_HPA);
> > 136         sysbus_mmio_map(s, 1, ARTIST_FB_ADDR);
> > 137     }
> >
> > The hppa boot-serial test use the default options, so the Artist chipset
> > is mapped, and the firmware test/use it.

Since gitweb seems broken...
https://git.qemu.org/git?p=seabios-hppa.git;a=commit;h=ba3c6473baf

Here is the relevant commit information:

- if Artist is mapped:
https://github.com/hdeller/seabios-hppa/commit/ba3c6473baf#diff-c47fa882864c690c7dc1dce8b4ac2c99R1739-R1742

- then use it as console (instead of the uart)
https://github.com/hdeller/seabios-hppa/commit/ba3c6473baf#diff-c47fa882864c690c7dc1dce8b4ac2c99R477-R483

> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Btw ;)
>
> > We can test like the 40p, using VGA_NONE:
> >
> > -- >8 --
> > diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
> > index 05c7f44457..971254ae62 100644
> > --- a/tests/qtest/boot-serial-test.c
> > +++ b/tests/qtest/boot-serial-test.c
> > @@ -135,7 +135,7 @@ static testdef_t tests[] = {
> >         sizeof(kernel_plml605), kernel_plml605 },
> >       { "moxie", "moxiesim", "", "TT", sizeof(bios_moxiesim), 0,
> > bios_moxiesim },
> >       { "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 },
> > -    { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
> > +    { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" },
> >       { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
> >         kernel_aarch64 },
> >       { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
> > ---
> >
> > You should squash this change in patch #7 (because it belongs there) but
> > please add a comment, because it is not obvious.
> >
> > Thanks,
> >
> > Phil.

Re: [PULL 00/11] target/hppa patch queue

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200122023256.27556-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200122023256.27556-1-richard.henderson@linaro.org
Subject: [PULL 00/11] target/hppa patch queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
fatal: git fetch_pack: expected ACK/NAK, got 'ERR upload-pack: not our ref 3a7b5a831c0398e93d120dcc654acefbb5056ee2'
fatal: The remote end hung up unexpectedly
error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384
Traceback (most recent call last):
  File "patchew-tester/src/patchew-cli", line 521, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester/src/patchew-cli", line 48, in git_clone_repo
    stdout=logf, stderr=logf)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', 'https://github.com/patchew-project/qemu']' returned non-zero exit status 1.



The full log is available at
http://patchew.org/logs/20200122023256.27556-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 00/11] target/hppa patch queue

[Philippe Mathieu-Daudé]

On 1/22/20 4:34 AM, no-reply@patchew.org wrote:
[...]
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> fatal: git fetch_pack: expected ACK/NAK, got 'ERR upload-pack: not our ref 3a7b5a831c0398e93d120dcc654acefbb5056ee2'
> fatal: The remote end hung up unexpectedly

Maybe we need something like 'travis_retry' for network issues (retry 3 
times, sleeping a bit between each).

https://docs.travis-ci.com/user/common-build-problems/#travis_retry
"Most of our internal build commands are wrapped with travis_retry to 
reduce the impact of network timeouts."

> error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Traceback (most recent call last):
>    File "patchew-tester/src/patchew-cli", line 521, in test_one
>      git_clone_repo(clone, r["repo"], r["head"], logf, True)
>    File "patchew-tester/src/patchew-cli", line 48, in git_clone_repo
>      stdout=logf, stderr=logf)
>    File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
>      raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', 'https://github.com/patchew-project/qemu']' returned non-zero exit status 1.
> 
> 
> 
> The full log is available at
> http://patchew.org/logs/20200122023256.27556-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>