From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
stefanha@linux.vnet.ibm.com, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCHv2 09/14] virtio-net: simplify rx code
Date: Tue, 25 Sep 2012 13:12:41 +0200 [thread overview]
Message-ID: <e82d87d36fec9402c843dfc8705cc3b863ece4ab.1348571185.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1348571185.git.mst@redhat.com>
Remove code duplication using guest header length that we track.
Drop specific layout requirement for rx buffers: things work
using generic iovec functions in any case.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio-net.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 358093e..86cd4a9 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -720,12 +720,7 @@ static int32_t virtio_net_flush_tx(VirtIONet *n, VirtQueue *vq)
struct iovec *out_sg = &elem.out_sg[0];
struct iovec sg[VIRTQUEUE_MAX_SIZE];
- /* hdr_len refers to the header received from the guest */
- hdr_len = n->mergeable_rx_bufs ?
- sizeof(struct virtio_net_hdr_mrg_rxbuf) :
- sizeof(struct virtio_net_hdr);
-
- if (out_num < 1 || out_sg->iov_len != hdr_len) {
+ if (out_num < 1) {
error_report("virtio-net header not in first element");
exit(1);
}
@@ -747,7 +742,7 @@ static int32_t virtio_net_flush_tx(VirtIONet *n, VirtQueue *vq)
out_sg = sg;
}
- len = hdr_len;
+ len = n->guest_hdr_len;
ret = qemu_sendv_packet_async(&n->nic->nc, out_sg, out_num,
virtio_net_tx_complete);
--
MST
next prev parent reply other threads:[~2012-09-25 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 11:12 [Qemu-devel] [PATCHv2 00/14] virtio-net: iovec handling cleanup Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 01/14] virtio-net: track host/guest header length Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 02/14] iov: add const annotation Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 03/14] iov: add iov_cpy Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 04/14] virtio-net: avoid sg copy Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 05/14] virtio-net: use safe iov operations for rx Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 06/14] virtio-net: refactor receive_hdr Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 07/14] virtio-net: first s/g is always at start of buf Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 08/14] virtio-net: switch tx to safe iov functions Michael S. Tsirkin
2012-09-25 11:12 ` Michael S. Tsirkin [this message]
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 10/14] virtio: don't mark unaccessed memory as dirty Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 11/14] virtio-net: fix used len for tx Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 12/14] virtio-net: minor code simplification Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 13/14] virtio-net: test peer header support at init time Michael S. Tsirkin
2012-09-25 11:13 ` [Qemu-devel] [PATCHv2 14/14] virtio-net: enable mrg buf header in tap on linux Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e82d87d36fec9402c843dfc8705cc3b863ece4ab.1348571185.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).