From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs
Date: Thu, 8 Mar 2018 16:10:27 +0100 [thread overview]
Message-ID: <e82f1fdd-1bba-76e7-212d-b676ca331205@vivier.eu> (raw)
In-Reply-To: <20180308144733.25615-3-peter.maydell@linaro.org>
Le 08/03/2018 à 15:47, Peter Maydell a écrit :
> Now we've dropped unicore32, all of the architectures we support
> for linux-user implement the signal handling routines. The
> dummy "just print a message" versions are unimplemented, so we
> can drop them entirely.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> IMHO signal handling support is too important to allow a
> hypothetical new architecture target to silently get away
> without implementing it. For initial development it's easy
> enough to stub out the per-architecture functions, and then
> we will have a clear view of which targets (if any) don't
> have the signal handling implemented yet, and the missing
> feature will show up in code review.
> ---
> linux-user/signal.c | 27 +--------------------------
> 1 file changed, 1 insertion(+), 26 deletions(-)
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2018-03-08 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 14:47 [Qemu-devel] [PATCH 0/2] Drop dead linux-user/unicore32 code Peter Maydell
2018-03-08 14:47 ` [Qemu-devel] [PATCH 1/2] linux-user: Drop unicore32 code Peter Maydell
2018-03-08 15:10 ` Laurent Vivier
2018-03-09 19:53 ` Laurent Vivier
2018-03-08 14:47 ` [Qemu-devel] [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs Peter Maydell
2018-03-08 15:10 ` Laurent Vivier [this message]
2018-03-09 19:54 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e82f1fdd-1bba-76e7-212d-b676ca331205@vivier.eu \
--to=laurent@vivier.eu \
--cc=gxt@mprc.pku.edu.cn \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).