From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etxBv-0005NM-6l for qemu-devel@nongnu.org; Thu, 08 Mar 2018 10:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etxBr-00045F-VW for qemu-devel@nongnu.org; Thu, 08 Mar 2018 10:10:47 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:55445) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etxBr-00044P-Kc for qemu-devel@nongnu.org; Thu, 08 Mar 2018 10:10:43 -0500 References: <20180308144733.25615-1-peter.maydell@linaro.org> <20180308144733.25615-3-peter.maydell@linaro.org> From: Laurent Vivier Message-ID: Date: Thu, 8 Mar 2018 16:10:27 +0100 MIME-Version: 1.0 In-Reply-To: <20180308144733.25615-3-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Riku Voipio , Guan Xuetao Le 08/03/2018 à 15:47, Peter Maydell a écrit : > Now we've dropped unicore32, all of the architectures we support > for linux-user implement the signal handling routines. The > dummy "just print a message" versions are unimplemented, so we > can drop them entirely. > > Signed-off-by: Peter Maydell > --- > IMHO signal handling support is too important to allow a > hypothetical new architecture target to silently get away > without implementing it. For initial development it's easy > enough to stub out the per-architecture functions, and then > we will have a clear view of which targets (if any) don't > have the signal handling implemented yet, and the missing > feature will show up in code review. > --- > linux-user/signal.c | 27 +-------------------------- > 1 file changed, 1 insertion(+), 26 deletions(-) > Reviewed-by: Laurent Vivier