From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI
Date: Fri, 2 Dec 2022 20:04:14 +0100 [thread overview]
Message-ID: <e84934e8-5a17-8598-f158-6bf9729c34ea@linaro.org> (raw)
In-Reply-To: <20221202174746.1218017-1-alex.bennee@linaro.org>
On 2/12/22 18:47, Alex Bennée wrote:
> Our CI system echos the lines it executes but not the expansions. For
> the sake of a line of extra verbosity during the configure phase lets
> echo the invocation of script to stdout as well as the log.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 26c7bc5154..849ac7aed9 100755
> --- a/configure
> +++ b/configure
> @@ -83,9 +83,10 @@ rm -f config.log
> # Print a helpful header at the top of config.log
> echo "# QEMU configure log $(date)" >> config.log
> printf "# Configured with:" >> config.log
> -printf " '%s'" "$0" "$@" >> config.log
> -echo >> config.log
> -echo "#" >> config.log
> +# repeat the invocation to log and stdout for CI
> +invoke=$(printf " '%s'" "$0" "$@")
> +echo "configuring with: $invoke"
test -n $GITLAB_CI && ... ?
> +{ echo "$invoke"; echo; echo "#"; } >> config.log
>
> quote_sh() {
> printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"
prev parent reply other threads:[~2022-12-02 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 17:47 [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI Alex Bennée
2022-12-02 19:04 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84934e8-5a17-8598-f158-6bf9729c34ea@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).