From: Paolo Bonzini <pbonzini@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 1/2] ppc: Fix build with --without-default-devices
Date: Thu, 24 Dec 2020 11:29:53 +0100 [thread overview]
Message-ID: <e84ce18f-5d8d-7ac5-3b3a-0dd9f0c939d1@redhat.com> (raw)
In-Reply-To: <490464a3-d8a6-1814-2a5c-681eca3b96fa@kaod.org>
On 24/12/20 09:26, Cédric Le Goater wrote:
> In hw/ppc/Kconfig :
>
> config POWERNV
> ...
> select XICS
> select XIVE
>
> config PSERIES
> ...
> select XICS_SPAPR
> select XIVE_SPAPR
>
> and in hw/intc/meson.build :
>
> specific_ss.add(when: 'CONFIG_POWERNV', if_true: files('xics_pnv.c', 'pnv_xive.c'))
> ...
> specific_ss.add(when: 'CONFIG_XICS_SPAPR', if_true: files('xics_spapr.c'))
> specific_ss.add(when: 'CONFIG_XIVE_SPAPR', if_true: files('spapr_xive.c'))
> ...
>
>
> Couldn't we simply select XICS and XIVE in the PSERIES machine and
> compile 'xics_spapr.c' and 'spapr_xive.c' when CONFIG_PSERIES is
> defined ? This to be in sync with the POWERNV machine.
> or introduce 'CONFIG_XICS_PNV 'CONFIG_XIVE_PNV' ?
I think just using CONFIG_PSERIES is the simplest. But it's just a
cleanup, not a bugfix.
Paolo
next prev parent reply other threads:[~2020-12-24 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 19:26 [PATCH v2 1/2] ppc: Fix build with --without-default-devices Greg Kurz
2020-12-23 19:26 ` [PATCH v2 2/2] pnv: Fix reverse dependency on PCI express root ports Greg Kurz
2020-12-24 10:28 ` Paolo Bonzini
2020-12-24 10:35 ` Cédric Le Goater
2020-12-24 8:26 ` [PATCH v2 1/2] ppc: Fix build with --without-default-devices Cédric Le Goater
2020-12-24 10:29 ` Paolo Bonzini [this message]
2020-12-24 10:34 ` Cédric Le Goater
2020-12-24 10:58 ` Philippe Mathieu-Daudé
2020-12-24 14:42 ` Paolo Bonzini
2020-12-24 15:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84ce18f-5d8d-7ac5-3b3a-0dd9f0c939d1@redhat.com \
--to=pbonzini@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).