From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg8rr-0006JO-Db for qemu-devel@nongnu.org; Wed, 05 Dec 2012 01:54:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tg8rq-0002uI-E1 for qemu-devel@nongnu.org; Wed, 05 Dec 2012 01:54:03 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:64458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg8rq-0002uC-7m for qemu-devel@nongnu.org; Wed, 05 Dec 2012 01:54:02 -0500 Received: by mail-pa0-f45.google.com with SMTP id bg2so3135075pad.4 for ; Tue, 04 Dec 2012 22:54:01 -0800 (PST) Sender: Peter Crosthwaite From: Peter Crosthwaite Date: Wed, 5 Dec 2012 16:53:43 +1000 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH v1 2/3] xilinx_uartlite: suppress "cannot receive message" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: edgar.iglesias@gmail.com, Peter Crosthwaite , peter.maydell@linaro.org This message is not an error condition, its just informing the user that the device is corking the uart traffic to not drop characters. Reported-by: Jason Wu Signed-off-by: Peter Crosthwaite --- hw/xilinx_uartlite.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/xilinx_uartlite.c b/hw/xilinx_uartlite.c index d20fc41..f890f23 100644 --- a/hw/xilinx_uartlite.c +++ b/hw/xilinx_uartlite.c @@ -182,12 +182,8 @@ static void uart_rx(void *opaque, const uint8_t *buf, int size) static int uart_can_rx(void *opaque) { struct xlx_uartlite *s = opaque; - int r; - r = s->rx_fifo_len < sizeof(s->rx_fifo); - if (!r) - printf("cannot receive!\n"); - return r; + return s->rx_fifo_len < sizeof(s->rx_fifo); } static void uart_event(void *opaque, int event) -- 1.7.0.4