From: Thomas Huth <thuth@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models
Date: Wed, 30 Aug 2017 16:44:53 +0200 [thread overview]
Message-ID: <e877e8ca-8e4f-f102-9b51-a29df8c1db7d@redhat.com> (raw)
In-Reply-To: <1504103170-259479-1-git-send-email-imammedo@redhat.com>
On 30.08.2017 16:26, Igor Mammedov wrote:
> only TODO escaped defines were meant to be removed,
> but not TODO_USER_ONLY which are compiled in case of
> *-user targets.
>
> So retirn back "440" model removed by mistake
>
> Spotted-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> target/ppc/cpu-models.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 611fc1b..08fb34b 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -150,6 +150,10 @@
> POWERPC_DEF("x2vp20", CPU_POWERPC_X2VP20, 405,
> NULL)
> /* PowerPC 440 family */
> +#if defined(TODO_USER_ONLY)
> + POWERPC_DEF("440", CPU_POWERPC_440, 440GP,
> + "Generic PowerPC 440")
> +#endif
> /* PowerPC 440 cores */
> POWERPC_DEF("440-xilinx", CPU_POWERPC_440_XILINX, 440x5,
> "PowerPC 440 Xilinx 5")
>
With this fixup patch added:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-08-30 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:24 [Qemu-devel] [PATCH v2 0/8] ppc: cpu_model handling cleanups Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 1/8] ppc: replace cpu_ppc_init() with cpu_generic_init() Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 2/8] ppc: use macros to make cpu type name from string literal Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 3/8] ppc: make cpu_model translation to type consistent Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 4/8] ppc: make cpu alias point only to real cpu models Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 5/8] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 6/8] ppc: simplify cpu model lookup by PVR Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 7/8] ppc: drop caching ObjectClass from PowerPCCPUAlias Igor Mammedov
2017-08-30 13:24 ` [Qemu-devel] [PATCH v2 8/8] ppc: remove non implemented cpu models Igor Mammedov
2017-08-30 13:46 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-08-30 14:14 ` Igor Mammedov
2017-08-30 14:26 ` [Qemu-devel] [PATCH v2 9/8] fixup! " Igor Mammedov
2017-08-30 14:44 ` Thomas Huth [this message]
2017-09-04 11:10 ` David Gibson
2017-09-04 13:05 ` Igor Mammedov
2017-08-31 7:58 ` [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] " Thomas Huth
2017-08-31 8:35 ` Igor Mammedov
2017-08-31 8:36 ` Thomas Huth
2017-09-04 4:29 ` [Qemu-devel] [PATCH v2 0/8] ppc: cpu_model handling cleanups David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e877e8ca-8e4f-f102-9b51-a29df8c1db7d@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).