From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn4En-0005hm-MB for qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:45:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn4El-0006s0-3Y for qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:45:01 -0400 References: <1504099475-241036-9-git-send-email-imammedo@redhat.com> <1504103170-259479-1-git-send-email-imammedo@redhat.com> From: Thomas Huth Message-ID: Date: Wed, 30 Aug 2017 16:44:53 +0200 MIME-Version: 1.0 In-Reply-To: <1504103170-259479-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, David Gibson On 30.08.2017 16:26, Igor Mammedov wrote: > only TODO escaped defines were meant to be removed, > but not TODO_USER_ONLY which are compiled in case of > *-user targets. > > So retirn back "440" model removed by mistake > > Spotted-by: Thomas Huth > Signed-off-by: Igor Mammedov > --- > target/ppc/cpu-models.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c > index 611fc1b..08fb34b 100644 > --- a/target/ppc/cpu-models.c > +++ b/target/ppc/cpu-models.c > @@ -150,6 +150,10 @@ > POWERPC_DEF("x2vp20", CPU_POWERPC_X2VP20, 405, > NULL) > /* PowerPC 440 family */ > +#if defined(TODO_USER_ONLY) > + POWERPC_DEF("440", CPU_POWERPC_440, 440GP, > + "Generic PowerPC 440") > +#endif > /* PowerPC 440 cores */ > POWERPC_DEF("440-xilinx", CPU_POWERPC_440_XILINX, 440x5, > "PowerPC 440 Xilinx 5") > With this fixup patch added: Reviewed-by: Thomas Huth