From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, sw@weilnetz.de
Subject: Re: [PATCH] meson: avoid unused arguments of main() in compiler tests
Date: Fri, 4 Nov 2022 08:27:48 +1100 [thread overview]
Message-ID: <e88339b1-7ffa-d044-2151-465409e61f90@linaro.org> (raw)
In-Reply-To: <20221103172110.168235-1-pbonzini@redhat.com>
On 11/4/22 04:21, Paolo Bonzini wrote:
> meson.build has one test where "main" is declared unnecessarily
> with argc and argv arguments, but does not use them. Because
> the test needs -Werror too, HAVE_BROKEN_SIZE_MAX is defined
> incorrectly.
>
> Fix the test and, for consistency, remove argc and argv whenever
> they are not needed.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> meson.build | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-11-03 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:21 [PATCH] meson: avoid unused arguments of main() in compiler tests Paolo Bonzini
2022-11-03 20:13 ` Stefan Weil via
2022-11-03 21:27 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88339b1-7ffa-d044-2151-465409e61f90@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).