From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v1 3/7] tests/tcg: remove extraneous pasting macros
Date: Fri, 27 Mar 2020 11:54:34 +0100 [thread overview]
Message-ID: <e8a9e9e3-7e7f-b143-ade0-a4440e146e9e@redhat.com> (raw)
In-Reply-To: <20200327094945.23768-4-alex.bennee@linaro.org>
On 3/27/20 10:49 AM, Alex Bennée wrote:
> We are not using them and they just get in the way.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/tcg/x86_64/system/boot.S | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/tcg/x86_64/system/boot.S b/tests/tcg/x86_64/system/boot.S
> index 205cfbd3982..73b19a2bda6 100644
> --- a/tests/tcg/x86_64/system/boot.S
> +++ b/tests/tcg/x86_64/system/boot.S
> @@ -41,10 +41,7 @@
> #define XEN_ELFNOTE_PHYS32_ENTRY 18
>
> #define __ASM_FORM(x) x
> -#define __ASM_FORM_RAW(x) x
> -#define __ASM_FORM_COMMA(x) x,
> -#define __ASM_SEL(a,b) __ASM_FORM(b)
> -#define __ASM_SEL_RAW(a,b) __ASM_FORM_RAW(b)
> +#define __ASM_SEL(a,b) __ASM_FORM(b)
> #define _ASM_PTR __ASM_SEL(.long, .quad)
>
> ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE, _ASM_PTR 0x100000)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-03-27 10:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 9:49 [PATCH for 5.0 v1 0/7] A selection of sanitiser fixes Alex Bennée
2020-03-27 9:49 ` [PATCH v1 1/7] elf-ops: bail out if we have no function symbols Alex Bennée
2020-03-27 10:53 ` Philippe Mathieu-Daudé
2020-03-27 11:10 ` Philippe Mathieu-Daudé
2020-03-27 11:45 ` Peter Maydell
2020-03-27 22:09 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 2/7] linux-user: protect fcntl64 with an #ifdef Alex Bennée
2020-03-27 10:40 ` Laurent Vivier
2020-03-27 22:10 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 3/7] tests/tcg: remove extraneous pasting macros Alex Bennée
2020-03-27 10:54 ` Philippe Mathieu-Daudé [this message]
2020-03-27 22:11 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 4/7] linux-user: more debug for init_guest_space Alex Bennée
2020-03-27 10:50 ` Laurent Vivier
2020-03-27 9:49 ` [PATCH v1 5/7] fpu/softfloat: avoid undefined behaviour when normalising empty sigs Alex Bennée
2020-03-27 10:09 ` Peter Maydell
2020-03-27 22:27 ` Richard Henderson
2020-03-27 22:33 ` Peter Maydell
2020-03-27 10:13 ` Aleksandar Markovic
2020-03-27 10:31 ` Alex Bennée
2020-03-27 9:49 ` [PATCH v1 6/7] target/xtensa: add FIXME for translation memory leak Alex Bennée
2020-03-27 9:49 ` [PATCH v1 7/7] gdbstub: fix compiler complaining Alex Bennée
2020-03-27 10:56 ` Philippe Mathieu-Daudé
2020-03-27 10:53 ` [PATCH for 5.0 v1 0/7] A selection of sanitiser fixes no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a9e9e3-7e7f-b143-ade0-a4440e146e9e@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).