qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-s390x <qemu-s390x@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-block@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] iotests: make 235 work on s390 (and others)
Date: Wed, 5 Dec 2018 09:34:32 -0600	[thread overview]
Message-ID: <e8aa64c4-4bfa-05e6-9a2f-6478330a6fd7@redhat.com> (raw)
In-Reply-To: <20181205084308.201356-1-borntraeger@de.ibm.com>

On 12/5/18 2:43 AM, Christian Borntraeger wrote:
> "-machine pc" will not work all architectures. Lets fall back to the
> default machine by not specifying it.
> 
> In addition we also need to specify -no-shutdown on s390 as qemu will
> exit otherwise.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

CC: qemu-stable

> ---
>   tests/qemu-iotests/235 | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Too late for 3.1; for that, we can just document that there are known 
iotests failures under some configurations

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-12-05 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  8:43 [Qemu-devel] [PATCH 1/1] iotests: make 235 work on s390 (and others) Christian Borntraeger
2018-12-05 15:34 ` Eric Blake [this message]
2018-12-07 12:12   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8aa64c4-4bfa-05e6-9a2f-6478330a6fd7@redhat.com \
    --to=eblake@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).