From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: zhao1.liu@intel.com, qemu-rust@nongnu.org
Subject: Re: [PATCH 10/10] rust: vmstate: make order of parameters consistent in vmstate_clock
Date: Wed, 22 Jan 2025 11:37:06 +0100 [thread overview]
Message-ID: <e8ba79eb-824f-4c9b-a224-026d5a3daa1a@linaro.org> (raw)
In-Reply-To: <20250117090046.1045010-11-pbonzini@redhat.com>
On 17/1/25 10:00, Paolo Bonzini wrote:
> Place struct_name before field_name, similar to offset_of.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/char/pl011/src/device_class.rs | 2 +-
> rust/qemu-api/src/vmstate.rs | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-01-22 10:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 9:00 [PATCH 00/10] rust: (mostly) type safe VMState Paolo Bonzini
2025-01-17 9:00 ` [PATCH 01/10] rust: vmstate: add new type safe implementation Paolo Bonzini
2025-01-17 9:00 ` [PATCH 02/10] rust: vmstate: implement VMState for non-leaf types Paolo Bonzini
2025-01-22 10:49 ` Zhao Liu
2025-01-17 9:00 ` [PATCH 03/10] rust: vmstate: add varray support to vmstate_of! Paolo Bonzini
2025-01-22 11:44 ` Zhao Liu
2025-01-17 9:00 ` [PATCH 04/10] rust: vmstate: implement Zeroable for VMStateField Paolo Bonzini
2025-01-17 9:00 ` [PATCH 05/10] rust: vmstate: implement VMState for scalar types Paolo Bonzini
2025-01-22 12:33 ` Zhao Liu
2025-01-22 17:28 ` Paolo Bonzini
2025-01-17 9:00 ` [PATCH 06/10] rust: vmstate: add public utility macros to implement VMState Paolo Bonzini
2025-01-17 9:00 ` [PATCH 07/10] rust: qemu_api: add vmstate_struct Paolo Bonzini
2025-01-22 13:17 ` Zhao Liu
2025-01-17 9:00 ` [PATCH 08/10] rust: pl011: switch vmstate to new-style macros Paolo Bonzini
2025-01-17 9:00 ` [PATCH 09/10] rust: vmstate: remove translation of C vmstate macros Paolo Bonzini
2025-01-17 9:00 ` [PATCH 10/10] rust: vmstate: make order of parameters consistent in vmstate_clock Paolo Bonzini
2025-01-22 10:37 ` Philippe Mathieu-Daudé [this message]
2025-01-22 13:18 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ba79eb-824f-4c9b-a224-026d5a3daa1a@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).