Re: [Qemu-devel] [Qemu-arm] [PATCH v1 06/12] target/arm: Decode aa32 armv8.1 three same

[Richard Henderson <richard.henderson@linaro.org>]

On 11/13/2017 05:55 PM, Alex Bennée wrote:
>> +        case NEON_3R_VFM_VQRDMLSH:
>> +            if (!u) {
>> +                /* VFM, VFMS */
>> +                if ((5 & (1 << size)) == 0) {
>> +                    return 1;
>> +                }
>> +                break;
>> +            }
>> +            /* VQRDMLSH */
>> +            switch (size) {
>> +            case 1:
>> +                fn_gvec_ptr = gen_helper_gvec_qrdmlsh_s16;
>> +                break;
>> +            case 2:
>> +                fn_gvec_ptr = gen_helper_gvec_qrdmlsh_s32;
>> +                break;
>> +            default:
>> +                return 1;
>> +            }
>> +            goto do_vqrdmlx;
> Could we not take the opportunity to re-factor out the common bit rather
> than make this mega 

What, specifically, did you have in mind?


r~