From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D9AC47082 for ; Thu, 3 Jun 2021 19:04:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13DA1610A8 for ; Thu, 3 Jun 2021 19:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DA1610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1losdQ-0000XI-1V for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 15:04:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loscg-00089s-O8 for qemu-devel@nongnu.org; Thu, 03 Jun 2021 15:03:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loscd-00008j-PS for qemu-devel@nongnu.org; Thu, 03 Jun 2021 15:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622746994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hpxzaNXlyfmPAOHCq3xOpbFtIdYWG8MfZzDuFtuHMJQ=; b=byZVa8f51hIbbgtQVJcfACxW+Xu5clmrwz4bso/h+T1dXl7UxmS6mUOzE88jlnkyzNAiba 9zG5mcd6vYmnp075P6g9BZv7rIJkU20dW/Pk3tgFvsIRJj+mxF7xY+ej+UgT6FCOofd8Tv SX+tIMGDK9EcZI/N6NSHR/hVpzle3wM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-mIXsRHZqOVSdF2Q_y6rIgg-1; Thu, 03 Jun 2021 15:03:09 -0400 X-MC-Unique: mIXsRHZqOVSdF2Q_y6rIgg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36352C7476; Thu, 3 Jun 2021 19:02:46 +0000 (UTC) Received: from [10.10.116.137] (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3554360D06; Thu, 3 Jun 2021 19:02:45 +0000 (UTC) Subject: Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket To: Emanuele Giuseppe Esposito , qemu-block@nongnu.org References: <20210520075236.44723-1-eesposit@redhat.com> <20210520075236.44723-2-eesposit@redhat.com> <5b53f903-1a11-7dec-fe4c-6dc16c066056@redhat.com> From: John Snow Message-ID: Date: Thu, 3 Jun 2021 15:02:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <5b53f903-1a11-7dec-fe4c-6dc16c066056@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.37, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.603, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel@nongnu.org, Max Reitz , Cleber Rosa , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/3/21 4:06 AM, Emanuele Giuseppe Esposito wrote: > > > On 03/06/2021 01:23, John Snow wrote: >> On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote: >>> Alsp add a new _qmp_timer field to the QEMUMachine class. >>> >>> Let's change the default socket timeout to None, so that if >>> a subclass needs to add a timer, it can be done by modifying >>> this private field. >>> >>> At the same time, restore the timer to be 15 seconds in iotests.py, to >>> give an upper bound to qemu-iotests execution. >>> >>> Signed-off-by: Emanuele Giuseppe Esposito >> >> Hi Emanuele: I'm sorry, but with the recent Python PR this no longer >> applies to origin/master -- the python files got shuffled around a bit >> when I added the new CI tests. >> >> May I please ask you to rebase? You don't have to re-spin just yet, >> just pointing me to the rebase would help me out. > > Hi John, no problem. I rebased here: > https://gitlab.com/eesposit/qemu/-/commits/qemu_iotests_io > > Let me know if I need to do anything else. > I will re-spin later today. > > Thank you, > Emanuele > Hi Emanuele: https://gitlab.com/jsnow/qemu/-/commits/review I added in a pylint ignore for you and these patches are clean now. --js