qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] rust: do not always select X_PL011_RUST
Date: Sun, 27 Oct 2024 14:15:34 +0100	[thread overview]
Message-ID: <e9094b82-8a23-45dc-b172-53d31abd9b32@redhat.com> (raw)
In-Reply-To: <m0e19.8g754qmy2u4@linaro.org>

On 10/27/24 10:49, Manos Pitsidianakis wrote:
> On Fri, 25 Oct 2024 12:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Right now the Rust pl011 device is included in all QEMU system
>> emulator binaries if --enable-rust is passed.  This is not needed
>> since the board logic in hw/arm/Kconfig will pick it.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> rust/hw/char/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/rust/hw/char/Kconfig b/rust/hw/char/Kconfig
>> index a1732a9e97f..5fe800c4806 100644
>> --- a/rust/hw/char/Kconfig
>> +++ b/rust/hw/char/Kconfig
>> @@ -1,3 +1,2 @@
>> config X_PL011_RUST
>>      bool
>> -    default y if HAVE_RUST
>> -- 
>> 2.47.0
> 
> (Do I need someone else reviewing this before picking this up in my
> tree?)
> 
> Acked-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

Oh, I wasn't aware that you were setting up a Rust tree, since you had 
asked me to include the first round of patches.  Generally "acked-by" 
means that you are *not* going to include it in your pull requests but 
are delegating this to someone else; which would work for me because I 
have this patch included in my next pull request, which I plan on 
sending out tomorrow.

Paolo



  reply	other threads:[~2024-10-27 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  9:42 [PATCH] rust: do not always select X_PL011_RUST Paolo Bonzini
2024-10-27  9:49 ` Manos Pitsidianakis
2024-10-27 13:15   ` Paolo Bonzini [this message]
2024-10-27 14:09     ` Manos Pitsidianakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9094b82-8a23-45dc-b172-53d31abd9b32@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).