[PATCH] rust: do not always select X_PL011_RUST

[PATCH] rust: do not always select X_PL011_RUST

[Paolo Bonzini]

Right now the Rust pl011 device is included in all QEMU system
emulator binaries if --enable-rust is passed.  This is not needed
since the board logic in hw/arm/Kconfig will pick it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rust/hw/char/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rust/hw/char/Kconfig b/rust/hw/char/Kconfig
index a1732a9e97f..5fe800c4806 100644
--- a/rust/hw/char/Kconfig
+++ b/rust/hw/char/Kconfig
@@ -1,3 +1,2 @@
 config X_PL011_RUST
     bool
-    default y if HAVE_RUST
-- 
2.47.0

Re: [PATCH] rust: do not always select X_PL011_RUST

[Manos Pitsidianakis]

On Fri, 25 Oct 2024 12:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>Right now the Rust pl011 device is included in all QEMU system
>emulator binaries if --enable-rust is passed.  This is not needed
>since the board logic in hw/arm/Kconfig will pick it.
>
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>---
> rust/hw/char/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/rust/hw/char/Kconfig b/rust/hw/char/Kconfig
>index a1732a9e97f..5fe800c4806 100644
>--- a/rust/hw/char/Kconfig
>+++ b/rust/hw/char/Kconfig
>@@ -1,3 +1,2 @@
> config X_PL011_RUST
>     bool
>-    default y if HAVE_RUST
>-- 
>2.47.0
>


(Do I need someone else reviewing this before picking this up in my 
tree?)

Acked-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

Re: [PATCH] rust: do not always select X_PL011_RUST

[Paolo Bonzini]

On 10/27/24 10:49, Manos Pitsidianakis wrote:
> On Fri, 25 Oct 2024 12:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Right now the Rust pl011 device is included in all QEMU system
>> emulator binaries if --enable-rust is passed.  This is not needed
>> since the board logic in hw/arm/Kconfig will pick it.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> rust/hw/char/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/rust/hw/char/Kconfig b/rust/hw/char/Kconfig
>> index a1732a9e97f..5fe800c4806 100644
>> --- a/rust/hw/char/Kconfig
>> +++ b/rust/hw/char/Kconfig
>> @@ -1,3 +1,2 @@
>> config X_PL011_RUST
>>      bool
>> -    default y if HAVE_RUST
>> -- 
>> 2.47.0
> 
> (Do I need someone else reviewing this before picking this up in my
> tree?)
> 
> Acked-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

Oh, I wasn't aware that you were setting up a Rust tree, since you had 
asked me to include the first round of patches.  Generally "acked-by" 
means that you are *not* going to include it in your pull requests but 
are delegating this to someone else; which would work for me because I 
have this patch included in my next pull request, which I plan on 
sending out tomorrow.

Paolo

Re: [PATCH] rust: do not always select X_PL011_RUST

[Manos Pitsidianakis]

On Sun, Oct 27, 2024 at 3:15 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 10/27/24 10:49, Manos Pitsidianakis wrote:
> > On Fri, 25 Oct 2024 12:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >> Right now the Rust pl011 device is included in all QEMU system
> >> emulator binaries if --enable-rust is passed.  This is not needed
> >> since the board logic in hw/arm/Kconfig will pick it.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >> ---
> >> rust/hw/char/Kconfig | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/rust/hw/char/Kconfig b/rust/hw/char/Kconfig
> >> index a1732a9e97f..5fe800c4806 100644
> >> --- a/rust/hw/char/Kconfig
> >> +++ b/rust/hw/char/Kconfig
> >> @@ -1,3 +1,2 @@
> >> config X_PL011_RUST
> >>      bool
> >> -    default y if HAVE_RUST
> >> --
> >> 2.47.0
> >
> > (Do I need someone else reviewing this before picking this up in my
> > tree?)
> >
> > Acked-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>
> Oh, I wasn't aware that you were setting up a Rust tree, since you had
> asked me to include the first round of patches.  Generally "acked-by"
> means that you are *not* going to include it in your pull requests but
> are delegating this to someone else; which would work for me because I
> have this patch included in my next pull request, which I plan on
> sending out tomorrow.
>
> Paolo
>

I wasn't in the MAINTAINERS list before that, thus had no tree for
pull requests, that's why. But yes you can pick this one sure.