qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Julian Ganz <neither@nut.email>
To: qemu-devel@nongnu.org
Cc: Julian Ganz <neither@nut.email>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org (open list:ARM TCG CPUs)
Subject: [PATCH v5 06/25] target/arm: call plugin trap callbacks
Date: Mon, 19 May 2025 17:19:46 +0200	[thread overview]
Message-ID: <e90a289ac289d98ebf9982de302d2655f96b22d3.1747666625.git.neither@nut.email> (raw)
In-Reply-To: <cover.1747666625.git.neither@nut.email>

We recently introduced API for registering callbacks for trap related
events as well as the corresponding hook functions. Due to differences
between architectures, the latter need to be called from target specific
code.

This change places hooks for ARM (and Aarch64) targets. We decided to
treat the (V)IRQ, (VI/VF)NMI, (V)FIQ and VSERR exceptions as interrupts
since they are, presumably, async in nature.

Signed-off-by: Julian Ganz <neither@nut.email>
---
 target/arm/helper.c       | 24 ++++++++++++++++++++++++
 target/arm/tcg/m_helper.c | 18 ++++++++++++++++++
 2 files changed, 42 insertions(+)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 7631210287..06070441a6 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -34,6 +34,7 @@
 #endif
 #include "cpregs.h"
 #include "target/arm/gtimer.h"
+#include "qemu/plugin.h"
 
 #define HELPER_H "tcg/helper.h"
 #include "exec/helper-proto.h.inc"
@@ -10214,6 +10215,24 @@ static void take_aarch32_exception(CPUARMState *env, int new_mode,
     }
 }
 
+static void arm_do_plugin_vcpu_interrupt_cb(CPUState *cs, uint64_t from)
+{
+    switch (cs->exception_index) {
+    case EXCP_IRQ:
+    case EXCP_VIRQ:
+    case EXCP_NMI:
+    case EXCP_VINMI:
+    case EXCP_FIQ:
+    case EXCP_VFIQ:
+    case EXCP_VFNMI:
+    case EXCP_VSERR:
+        qemu_plugin_vcpu_interrupt_cb(cs, from);
+        break;
+    default:
+        qemu_plugin_vcpu_exception_cb(cs, from);
+    }
+}
+
 static void arm_cpu_do_interrupt_aarch32_hyp(CPUState *cs)
 {
     /*
@@ -10880,6 +10899,7 @@ void arm_cpu_do_interrupt(CPUState *cs)
     ARMCPU *cpu = ARM_CPU(cs);
     CPUARMState *env = &cpu->env;
     unsigned int new_el = env->exception.target_el;
+    uint64_t last_pc = env->pc;
 
     assert(!arm_feature(env, ARM_FEATURE_M));
 
@@ -10896,6 +10916,7 @@ void arm_cpu_do_interrupt(CPUState *cs)
     if (tcg_enabled() && arm_is_psci_call(cpu, cs->exception_index)) {
         arm_handle_psci_call(cpu);
         qemu_log_mask(CPU_LOG_INT, "...handled as PSCI call\n");
+        qemu_plugin_vcpu_hostcall_cb(cs, last_pc);
         return;
     }
 
@@ -10907,6 +10928,7 @@ void arm_cpu_do_interrupt(CPUState *cs)
 #ifdef CONFIG_TCG
     if (cs->exception_index == EXCP_SEMIHOST) {
         tcg_handle_semihosting(cs);
+        qemu_plugin_vcpu_hostcall_cb(cs, last_pc);
         return;
     }
 #endif
@@ -10932,6 +10954,8 @@ void arm_cpu_do_interrupt(CPUState *cs)
     if (!kvm_enabled()) {
         cs->interrupt_request |= CPU_INTERRUPT_EXITTB;
     }
+
+    arm_do_plugin_vcpu_interrupt_cb(cs, last_pc);
 }
 #endif /* !CONFIG_USER_ONLY */
 
diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c
index 6614719832..bcb4aae0d5 100644
--- a/target/arm/tcg/m_helper.c
+++ b/target/arm/tcg/m_helper.c
@@ -23,6 +23,7 @@
 #if !defined(CONFIG_USER_ONLY)
 #include "hw/intc/armv7m_nvic.h"
 #endif
+#include "qemu/plugin.h"
 
 static void v7m_msr_xpsr(CPUARMState *env, uint32_t mask,
                          uint32_t reg, uint32_t val)
@@ -2185,6 +2186,7 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)
     CPUARMState *env = &cpu->env;
     uint32_t lr;
     bool ignore_stackfaults;
+    uint64_t last_pc = env->pc;
 
     arm_log_exception(cs);
 
@@ -2352,6 +2354,7 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)
         g_assert_not_reached();
 #endif
         env->regs[15] += env->thumb ? 2 : 4;
+        qemu_plugin_vcpu_hostcall_cb(cs, last_pc);
         return;
     case EXCP_BKPT:
         armv7m_nvic_set_pending(env->nvic, ARMV7M_EXCP_DEBUG, false);
@@ -2418,6 +2421,21 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)
 
     ignore_stackfaults = v7m_push_stack(cpu);
     v7m_exception_taken(cpu, lr, false, ignore_stackfaults);
+
+    switch (cs->exception_index) {
+    case EXCP_IRQ:
+    case EXCP_VIRQ:
+    case EXCP_NMI:
+    case EXCP_VINMI:
+    case EXCP_FIQ:
+    case EXCP_VFIQ:
+    case EXCP_VFNMI:
+    case EXCP_VSERR:
+        qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
+        break;
+    default:
+        qemu_plugin_vcpu_exception_cb(cs, last_pc);
+    }
 }
 
 uint32_t HELPER(v7m_mrs)(CPUARMState *env, uint32_t reg)
-- 
2.49.0



  parent reply	other threads:[~2025-05-19 15:25 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 15:19 [PATCH v5 00/25] tcg-plugins: add hooks for discontinuities Julian Ganz
2025-05-19 15:19 ` [PATCH v5 01/25] plugins: add types for callbacks related to certain discontinuities Julian Ganz
2025-05-24 16:43   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 02/25] plugins: add API for registering discontinuity callbacks Julian Ganz
2025-05-24 16:48   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 03/25] plugins: add hooks for new discontinuity related callbacks Julian Ganz
2025-05-24 16:55   ` Richard Henderson
2025-05-25 20:56     ` Julian Ganz
2025-05-26  8:08       ` Julian Ganz
2025-05-26  9:02         ` Richard Henderson
2025-05-24 17:27   ` Richard Henderson
2025-05-25 20:56     ` Julian Ganz
2025-05-19 15:19 ` [PATCH v5 04/25] contrib/plugins: add plugin showcasing new dicontinuity related API Julian Ganz
2025-05-19 15:19 ` [PATCH v5 05/25] target/alpha: call plugin trap callbacks Julian Ganz
2025-05-24 16:56   ` Richard Henderson
2025-05-25 12:14   ` Richard Henderson
2025-05-25 20:16     ` Julian Ganz
2025-05-26  9:01       ` Richard Henderson
2025-05-26  9:54         ` Julian Ganz
2025-05-26 16:22           ` Richard Henderson
2025-05-19 15:19 ` Julian Ganz [this message]
2025-05-24 17:05   ` [PATCH v5 06/25] target/arm: " Richard Henderson
2025-05-19 15:19 ` [PATCH v5 07/25] target/avr: " Julian Ganz
2025-05-24 17:06   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 08/25] target/hppa: " Julian Ganz
2025-05-24 17:07   ` Richard Henderson
2025-05-24 23:19     ` Julian Ganz
2025-05-19 15:19 ` [PATCH v5 09/25] target/i386: " Julian Ganz
2025-05-19 15:19 ` [PATCH v5 10/25] target/loongarch: " Julian Ganz
2025-05-24 17:10   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 11/25] target/m68k: " Julian Ganz
2025-05-24 17:19   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 12/25] target/microblaze: " Julian Ganz
2025-05-24 17:21   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 13/25] target/mips: " Julian Ganz
2025-05-24 17:23   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 14/25] target/openrisc: " Julian Ganz
2025-05-24 17:25   ` Richard Henderson
2025-05-25 20:56     ` Julian Ganz
2025-05-19 15:19 ` [PATCH v5 15/25] target/ppc: " Julian Ganz
2025-05-24 17:30   ` Richard Henderson
2025-05-26 10:04     ` Julian Ganz
2025-05-19 15:19 ` [PATCH v5 16/25] target/riscv: " Julian Ganz
2025-05-19 15:19 ` [PATCH v5 17/25] target/rx: " Julian Ganz
2025-05-24 17:34   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 18/25] target/s390x: " Julian Ganz
2025-05-24 17:36   ` Richard Henderson
2025-05-19 15:19 ` [PATCH v5 19/25] target/sh4: " Julian Ganz
2025-05-24 17:38   ` Richard Henderson
2025-05-19 15:20 ` [PATCH v5 20/25] target/sparc: " Julian Ganz
2025-05-24 17:41   ` Richard Henderson
2025-05-19 15:20 ` [PATCH v5 21/25] target/tricore: " Julian Ganz
2025-05-20 14:25   ` Bastian Koppelmann
2025-05-24 17:44   ` Richard Henderson
2025-05-19 15:20 ` [PATCH v5 22/25] target/xtensa: " Julian Ganz
2025-05-19 15:24 ` [PATCH v5 23/25] tests: add plugin asserting correctness of discon event's to_pc Julian Ganz
2025-05-20 20:01   ` Pierrick Bouvier
2025-05-20 20:44     ` Julian Ganz
2025-05-20 21:09       ` Pierrick Bouvier
2025-05-21 19:03         ` Pierrick Bouvier
2025-05-19 15:24 ` [PATCH v5 24/25] tests: add test for double-traps on rv64 Julian Ganz
2025-05-19 15:24 ` [PATCH v5 25/25] tests: add test with interrupted memory accesses " Julian Ganz
2025-09-02 10:20 ` [PATCH v5 00/25] tcg-plugins: add hooks for discontinuities Alex Bennée
2025-09-02 11:49   ` Julian Ganz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e90a289ac289d98ebf9982de302d2655f96b22d3.1747666625.git.neither@nut.email \
    --to=neither@nut.email \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).