From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/9] monitor: Remove unused monitor_print_filename
Date: Fri, 21 Mar 2014 19:42:23 -0400 [thread overview]
Message-ID: <e91282c2f895827c9aeaa27f4f3b68da7984fa94.1395445063.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1395445063.git.crobinso@redhat.com>
In-Reply-To: <cover.1395445063.git.crobinso@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
include/monitor/monitor.h | 1 -
monitor.c | 27 ---------------------------
stubs/Makefile.objs | 1 -
stubs/mon-print-filename.c | 6 ------
4 files changed, 35 deletions(-)
delete mode 100644 stubs/mon-print-filename.c
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index a49ea11..42d8671 100644
--- a/include/monitor/monitor.h
+++ b/include/monitor/monitor.h
@@ -79,7 +79,6 @@ int monitor_handle_fd_param(Monitor *mon, const char *fdname);
void monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)
GCC_FMT_ATTR(2, 0);
void monitor_printf(Monitor *mon, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
-void monitor_print_filename(Monitor *mon, const char *filename);
void monitor_flush(Monitor *mon);
int monitor_set_cpu(int cpu_index);
int monitor_get_cpu_index(void);
diff --git a/monitor.c b/monitor.c
index 342e83b..c8428a1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -352,33 +352,6 @@ void monitor_printf(Monitor *mon, const char *fmt, ...)
va_end(ap);
}
-void monitor_print_filename(Monitor *mon, const char *filename)
-{
- int i;
-
- for (i = 0; filename[i]; i++) {
- switch (filename[i]) {
- case ' ':
- case '"':
- case '\\':
- monitor_printf(mon, "\\%c", filename[i]);
- break;
- case '\t':
- monitor_printf(mon, "\\t");
- break;
- case '\r':
- monitor_printf(mon, "\\r");
- break;
- case '\n':
- monitor_printf(mon, "\\n");
- break;
- default:
- monitor_printf(mon, "%c", filename[i]);
- break;
- }
- }
-}
-
static int GCC_FMT_ATTR(2, 3) monitor_fprintf(FILE *stream,
const char *fmt, ...)
{
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index 5ed1d38..d99e2b9 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -14,7 +14,6 @@ stub-obj-y += iothread-lock.o
stub-obj-y += migr-blocker.o
stub-obj-y += mon-is-qmp.o
stub-obj-y += mon-printf.o
-stub-obj-y += mon-print-filename.o
stub-obj-y += mon-protocol-event.o
stub-obj-y += mon-set-error.o
stub-obj-y += pci-drive-hot-add.o
diff --git a/stubs/mon-print-filename.c b/stubs/mon-print-filename.c
deleted file mode 100644
index 9c93964..0000000
--- a/stubs/mon-print-filename.c
+++ /dev/null
@@ -1,6 +0,0 @@
-#include "qemu-common.h"
-#include "monitor/monitor.h"
-
-void monitor_print_filename(Monitor *mon, const char *filename)
-{
-}
--
1.8.5.3
next prev parent reply other threads:[~2014-03-21 23:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 23:42 [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 1/9] slirp: Remove default_mon usage Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 2/9] vnc: " Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 3/9] error: Privatize error_print_loc Cole Robinson
2014-03-21 23:42 ` Cole Robinson [this message]
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if using qmp Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 6/9] qerror.h: Remove unused error classes Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 7/9] qerror.h: Remove QERR defines that are only used once Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 8/9] qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED Cole Robinson
2014-03-21 23:42 ` [Qemu-devel] [PATCH v2 9/9] error: Remove some unused headers Cole Robinson
2014-03-22 9:06 ` [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements Paolo Bonzini
2014-03-27 20:57 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e91282c2f895827c9aeaa27f4f3b68da7984fa94.1395445063.git.crobinso@redhat.com \
--to=crobinso@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).