From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb3Dn-0000Ev-BQ for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb3Dm-0000Zy-Ch for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb3Dm-0000Zu-5I for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:38 -0500 From: Amit Shah Date: Wed, 21 Nov 2012 11:21:19 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH v2 2/4] virtio-rng: remove extra request for entropy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , Paolo Bonzini , qemu list If we got fewer bytes from the backend than requested, don't poke the backend for more bytes; the guest will ask for more (or if the guest has already asked for more, the backend knows about it via handle_input()). Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori --- hw/virtio-rng.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index 6c49bb2..cf5a8ff 100644 --- a/hw/virtio-rng.c +++ b/hw/virtio-rng.c @@ -80,13 +80,6 @@ static void chr_read(void *opaque, const void *buf, size_t size) virtqueue_push(vrng->vq, &elem, len); } virtio_notify(&vrng->vdev, vrng->vq); - - /* - * Lastly, if we had multiple elems queued by the guest, and we - * didn't have enough data to fill them all, indicate we want more - * data. - */ - virtio_rng_process(vrng); } static void virtio_rng_process(VirtIORNG *vrng) -- 1.8.0