From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bosU0-0005Nf-Ds for qemu-devel@nongnu.org; Tue, 27 Sep 2016 09:31:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bosTy-00017u-IG for qemu-devel@nongnu.org; Tue, 27 Sep 2016 09:31:39 -0400 References: <1474974892-5031-1-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: Date: Tue, 27 Sep 2016 08:31:29 -0500 MIME-Version: 1.0 In-Reply-To: <1474974892-5031-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qRgHiS22ued8OW2LfuE0s2OshqeQh6PP0" Subject: Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qRgHiS22ued8OW2LfuE0s2OshqeQh6PP0 From: Eric Blake To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-block@nongnu.org, Max Reitz Message-ID: Subject: Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit References: <1474974892-5031-1-git-send-email-famz@redhat.com> In-Reply-To: <1474974892-5031-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use case, where a temporary > overlay is created and fstrim'ed before commiting back, to free space i= n s/commiting/committing/ > the original image. >=20 > This also enables it for block-commit. >=20 > Signed-off-by: Fam Zheng > --- > v3: Change the right parameter. > v2: Add "unmap" to block-commit as well. [Kevin] > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qRgHiS22ued8OW2LfuE0s2OshqeQh6PP0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX6nSxAAoJEKeha0olJ0Nqe24H/1CL1i0np/lab3J90FLDQiVL SgXdQLxfHYwOEDLjAjr3vbEXkHwNdNOMpplfTPTJSp5nQ3dej03q4fqRLKwPa1Ys M80WZW3DGyzLdu/SuKABhOB6ltPFoXcnb0zP8k/5VhVD0/InLzTbU3i9UudbTTtu 9BLPWhHnVYKmrIvpdZ9CZqsNYncYQaefee2RcnpVsfkZw7h1/s4pNnKrLRyHuphv 3YhGmWmJnnIwCYjjyLPBGHihchvRPL0y7xaPsEPfV8nFIH9iwApO7UTatUQtL3se miY/9gcVV54C+UIX4mI175OvdjiNmLIePUy4xWKclZ5rnt2VZIMgTj70c3ELqNE= =h6ir -----END PGP SIGNATURE----- --qRgHiS22ued8OW2LfuE0s2OshqeQh6PP0--