From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit
Date: Wed, 15 Apr 2020 16:09:18 -0500 [thread overview]
Message-ID: <e92c15c0-6233-44ce-924e-2ef6c32a6ea4@redhat.com> (raw)
In-Reply-To: <20200415190207.21118-1-berto@igalia.com>
On 4/15/20 2:02 PM, Alberto Garcia wrote:
> Although we cannot create these images with qemu-img it is still
> possible to do it using an external tool. QEMU should refuse to open
> them until the data-file-raw bit is cleared with 'qemu-img check'.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2.c | 39 ++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/244 | 13 +++++++++++++
> tests/qemu-iotests/244.out | 14 ++++++++++++++
> 3 files changed, 66 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-15 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 19:02 [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit Alberto Garcia
2020-04-15 21:09 ` Eric Blake [this message]
2020-05-19 17:46 ` Alberto Garcia
2020-06-03 13:53 ` Max Reitz
2020-06-05 11:14 ` Kevin Wolf
2020-06-05 12:11 ` Max Reitz
2020-06-05 13:00 ` Kevin Wolf
2020-06-05 14:38 ` Max Reitz
2020-06-18 12:03 ` Alberto Garcia
2020-06-19 7:57 ` Max Reitz
2020-06-19 11:06 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92c15c0-6233-44ce-924e-2ef6c32a6ea4@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).