From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CDF1C2BA19 for ; Wed, 15 Apr 2020 21:10:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 338872076D for ; Wed, 15 Apr 2020 21:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZaDaJO9x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 338872076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOpIV-0000II-DN for qemu-devel@archiver.kernel.org; Wed, 15 Apr 2020 17:10:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41884) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOpHm-00087l-3B for qemu-devel@nongnu.org; Wed, 15 Apr 2020 17:09:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOpHk-0001KV-1l for qemu-devel@nongnu.org; Wed, 15 Apr 2020 17:09:29 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27922 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOpHj-0001H1-Ri for qemu-devel@nongnu.org; Wed, 15 Apr 2020 17:09:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586984966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fZrDoQNbw+F8d9l7a6RNt/EFy7Ux+jXNyUAw/V+SR/I=; b=ZaDaJO9xIi0bK1b2N/DQMS/CmOZTHKrJg1qWc6MksaLtcgHd/3EwwNEdyOjfQnIREes4j2 edU2kqOofA7JsBsdF10YvnrEfw4ISAQn/gfJezhhwH2YTGntL4XNbDBgb3JgyW/Pol+Xw9 S62i9SyagowYvtMKDc1MbrUOZCgQ1Ik= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-4zUWwGaSOwuP03zSAYYngQ-1; Wed, 15 Apr 2020 17:09:22 -0400 X-MC-Unique: 4zUWwGaSOwuP03zSAYYngQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EFF818B9FC1; Wed, 15 Apr 2020 21:09:20 +0000 (UTC) Received: from [10.3.115.59] (ovpn-115-59.phx2.redhat.com [10.3.115.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFE2410013A1; Wed, 15 Apr 2020 21:09:18 +0000 (UTC) Subject: Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit To: Alberto Garcia , qemu-devel@nongnu.org References: <20200415190207.21118-1-berto@igalia.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 15 Apr 2020 16:09:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200415190207.21118-1-berto@igalia.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/15/20 2:02 PM, Alberto Garcia wrote: > Although we cannot create these images with qemu-img it is still > possible to do it using an external tool. QEMU should refuse to open > them until the data-file-raw bit is cleared with 'qemu-img check'. > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 39 ++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/244 | 13 +++++++++++++ > tests/qemu-iotests/244.out | 14 ++++++++++++++ > 3 files changed, 66 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org