From: Paolo Bonzini <pbonzini@redhat.com>
To: "Stefan Weil" <sw@weilnetz.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <rth@twiddle.net>,
"Jiang Yunhong" <yunhong.jiang@intel.com>,
"Vincent Palatin" <vpalatin@chromium.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/
Date: Thu, 14 Sep 2017 13:40:31 +0200 [thread overview]
Message-ID: <e9714f5a-b328-8f6c-6cca-725f0851bc66@redhat.com> (raw)
In-Reply-To: <2acadeb5-41e1-ce09-6e3b-37001dd57042@weilnetz.de>
On 14/09/2017 05:30, Stefan Weil wrote:
> Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé:
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Makefile.target | 1 -
>> hax-stub.c => accel/stubs/hax-stub.c | 0
>> accel/stubs/Makefile.objs | 1 +
>> 3 files changed, 1 insertion(+), 1 deletion(-)
>> rename hax-stub.c => accel/stubs/hax-stub.c (100%)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 6361f957fb..af4b60d012 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -101,7 +101,6 @@ obj-y += fpu/softfloat.o
>> obj-y += target/$(TARGET_BASE_ARCH)/
>> obj-y += disas.o
>> obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
>> -obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>>
>> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
>> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
>> diff --git a/hax-stub.c b/accel/stubs/hax-stub.c
>> similarity index 100%
>> rename from hax-stub.c
>> rename to accel/stubs/hax-stub.c
>> diff --git a/accel/stubs/Makefile.objs b/accel/stubs/Makefile.objs
>> index fdfbf7332c..8038ad6553 100644
>> --- a/accel/stubs/Makefile.objs
>> +++ b/accel/stubs/Makefile.objs
>> @@ -1,2 +1,3 @@
>> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
>> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
>> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Personally, I like alphabetic order for such lines.
> Maybe that can be done when it is applied.
Done and queued, thanks both.
Paolo
prev parent reply other threads:[~2017-09-14 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 22:11 [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/ Philippe Mathieu-Daudé
2017-09-14 3:30 ` Stefan Weil
2017-09-14 4:46 ` Philippe Mathieu-Daudé
2017-09-14 11:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9714f5a-b328-8f6c-6cca-725f0851bc66@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=vpalatin@chromium.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).