From: Thomas Huth <thuth@redhat.com>
To: ganqixin <ganqixin@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Cc: "Chenqun \(kuhn\)" <kuhn.chenqun@huawei.com>,
Zhanghailiang <zhang.zhanghailiang@huawei.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category
Date: Mon, 7 Dec 2020 09:52:42 +0100 [thread overview]
Message-ID: <e97a996d-3f22-bf1d-15f4-f53247e0beb4@redhat.com> (raw)
In-Reply-To: <A5B86EC83C48EF4CB2BC58BEF3A2F496065E4158@DGGEMI525-MBS.china.huawei.com>
On 07/12/2020 09.05, ganqixin wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
>> Sent: Friday, December 4, 2020 9:50 PM
>> To: ganqixin <ganqixin@huawei.com>; qemu-devel@nongnu.org;
>> qemu-trivial@nongnu.org
>> Cc: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; Zhanghailiang
>> <zhang.zhanghailiang@huawei.com>; Gerd Hoffmann
>> <kraxel@redhat.com>; thuth@redhat.com
>> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category
>>
>> On 11/17/20 2:37 PM, ganqixin wrote:
>>>> -----Original Message-----
>>>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
>>>> Sent: Monday, November 16, 2020 10:05 PM
>>>> To: ganqixin <ganqixin@huawei.com>; qemu-devel@nongnu.org;
>>>> qemu-trivial@nongnu.org; Marc-André Lureau
>>>> <marcandre.lureau@redhat.com>; thuth@redhat.com
>>>> Cc: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; Zhanghailiang
>>>> <zhang.zhanghailiang@huawei.com>; Gerd Hoffmann
>> <kraxel@redhat.com>;
>>>> Eduardo Habkost <ehabkost@redhat.com>
>>>> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb'
>>>> category
>>>>
>>>> On 11/15/20 7:48 PM, Gan Qixin wrote:
>>>>> The category of the u2f-passthru device is not set, put it into the 'usb'
>>>>> category.
>>>>
>>>> I guess we discussed this with Thomas 1 or 2 years ago but I don't
>> remember.
>>>> I think it was about using set_bits() so devices can appear in
>>>> multiple categories.
>>>>
>>>> Gerd, do you know what is the point of the "usb" category for
>>>> management apps? This is a bus accepting multiple better categorized
>>>> devices (display, storage, input, network, sound).
>>>>
>>>> Unrelated but multiple devices are related to SECURITY.
>>>> Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY?
>>>
>>> Hi, Philippe
>>> Thanks for your reply, but I'm not sure if it is appropriate to add a
>> security category to place this device.
>>> (Maybe it's because I don't know much about these device, I haven't
>>> find many safety-related devices in 'misc' category or uncategorized
>>> devices)
>>
>> What is the difference between 'misc' and 'uncategorized'?
>
> In my opinion, devices that we forgot to classify will appear in "uncategorized" list, and devices that don't have a suitable category to choose will be put into "misc" category.
That's right. User-creatable devices should have a category, and the
uncategorized devices just have not been categorized yet.
So thanks for tackling this, Gan Qixin!
Thomas
next prev parent reply other threads:[~2020-12-07 8:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:48 [PATCH 00/13] Categorize some uncategorized devices Gan Qixin
2020-11-15 18:48 ` [PATCH 01/13] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 02/13] virtio-pmem: " Gan Qixin
2020-11-19 14:12 ` Pankaj Gupta
2020-12-04 7:24 ` Pankaj Gupta
2020-11-15 18:48 ` [PATCH 03/13] vmmouse: put it into the 'input' category Gan Qixin
2020-11-16 14:05 ` Philippe Mathieu-Daudé
2020-11-15 18:48 ` [PATCH 04/13] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 05/13] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 06/13] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-15 18:48 ` [PATCH 07/13] tpm: put some tpm " Gan Qixin
2020-11-15 18:48 ` [PATCH 08/13] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 09/13] u2f-passthru: put it into the 'usb' category Gan Qixin
2020-11-16 14:04 ` Philippe Mathieu-Daudé
2020-11-17 6:58 ` Gerd Hoffmann
2020-11-17 13:40 ` ganqixin
2020-11-17 13:37 ` ganqixin
2020-12-04 13:50 ` Philippe Mathieu-Daudé
2020-12-07 8:05 ` ganqixin
2020-12-07 8:52 ` Thomas Huth [this message]
2020-11-15 18:49 ` [PATCH 10/13] tosa-ssp: put it into the 'misc' category Gan Qixin
2020-11-15 18:49 ` [PATCH 11/13] spitz: put some Spitz-family devices into the correct category Gan Qixin
2020-11-15 18:49 ` [PATCH 12/13] SPI flash devices: put them into the 'storage' category Gan Qixin
2020-11-16 13:59 ` Philippe Mathieu-Daudé
2020-11-16 16:19 ` Alistair Francis
2020-11-15 18:49 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category Gan Qixin
2020-11-16 13:25 ` Philippe Mathieu-Daudé
2020-11-16 13:31 ` Peter Maydell
2020-11-16 14:33 ` Thomas Huth
2020-11-16 14:30 ` Thomas Huth
2020-11-16 17:00 ` Markus Armbruster
2020-11-16 17:15 ` Peter Maydell
2020-11-17 5:41 ` Markus Armbruster
2020-11-17 11:08 ` Peter Maydell
2020-11-17 20:12 ` Thomas Huth
2020-11-18 8:41 ` Markus Armbruster
2020-11-18 8:50 ` Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category) Markus Armbruster
2020-11-18 9:08 ` Thomas Huth
2020-11-17 14:02 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category ganqixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e97a996d-3f22-bf1d-15f4-f53247e0beb4@redhat.com \
--to=thuth@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kraxel@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).