From: Thomas Huth <thuth@redhat.com>
To: "Bin Meng" <bmeng.cn@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"Bin Meng" <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Minwoo Im" <minwoo.im.dev@gmail.com>,
"Keith Busch" <kbusch@kernel.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()
Date: Wed, 10 Feb 2021 12:23:59 +0100 [thread overview]
Message-ID: <e982a505-fddd-0883-1ab2-13bf188396e3@redhat.com> (raw)
In-Reply-To: <CAEUhbmXaSDauxVaEdBt2yvbAq3_LC6bsHiwF+T6Qgf9mSmcy-w@mail.gmail.com>
On 10/02/2021 12.15, Bin Meng wrote:
> Hi Philippe,
>
> On Wed, Feb 10, 2021 at 7:12 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> Hi Bin,
>>
>> On 2/10/21 11:23 AM, Bin Meng wrote:
>>> From: Bin Meng <bin.meng@windriver.com>
>>>
>>> Current QEMU HEAD nvme.c does not compile:
>>>
>>> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
>>> ^
>>> hw/block/nvme.c:3150:14: note: ‘result’ was declared here
>>> uint32_t result;
>>> ^
>>
>> Why isn't this catched by our CI? What is your host OS? Fedora 33?
>>
>
> I am using GCC 5.4 on Ubuntu 16.04. Please see some initial analysis
> from Peter about why newer version GCC does not report it.
Please note that Ubuntu 16.04 is not a supported version by QEMU anymore,
see https://qemu.readthedocs.io/en/latest/system/build-platforms.html and
https://wiki.qemu.org/Supported_Build_Platforms for details.
Thomas
next prev parent reply other threads:[~2021-02-10 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:23 [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() Bin Meng
2021-02-10 10:42 ` Klaus Jensen
2021-02-10 10:47 ` Minwoo Im
2021-02-10 11:12 ` Philippe Mathieu-Daudé
2021-02-10 11:15 ` Bin Meng
2021-02-10 11:23 ` Thomas Huth [this message]
2021-02-10 11:15 ` Philippe Mathieu-Daudé
2021-02-10 11:17 ` Bin Meng
2021-02-10 11:22 ` Daniel P. Berrangé
2021-02-10 11:34 ` Daniel P. Berrangé
2021-02-10 22:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e982a505-fddd-0883-1ab2-13bf188396e3@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).