qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Zhang, Chen" <chen.zhang@intel.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: RE: [PATCH 2/3] colo-compare: fix missing compare_seq initialization
Date: Wed, 23 Sep 2020 01:42:53 +0000	[thread overview]
Message-ID: <e98329b97e8947d7a4b0d4c941fbb20e@intel.com> (raw)
In-Reply-To: <20200922095525.4081603-3-lizhijian@cn.fujitsu.com>



> -----Original Message-----
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
> Sent: Tuesday, September 22, 2020 5:55 PM
> To: Zhang, Chen <chen.zhang@intel.com>; jasowang@redhat.com
> Cc: qemu-devel@nongnu.org; Li Zhijian <lizhijian@cn.fujitsu.com>
> Subject: [PATCH 2/3] colo-compare: fix missing compare_seq initialization
> 
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

Reviewed-by: Zhang Chen <chen.zhang@intel.com>

Thanks
Zhang Chen

> ---
>  net/colo.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/colo.c b/net/colo.c
> index a6c66d829a..ef00609848 100644
> --- a/net/colo.c
> +++ b/net/colo.c
> @@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key)
> 
>  Connection *connection_new(ConnectionKey *key)  {
> -    Connection *conn = g_slice_new(Connection);
> +    Connection *conn = g_slice_new0(Connection);
> 
>      conn->ip_proto = key->ip_proto;
>      conn->processing = false;
> -    conn->offset = 0;
>      conn->tcp_state = TCPS_CLOSED;
> -    conn->pack = 0;
> -    conn->sack = 0;
>      g_queue_init(&conn->primary_list);
>      g_queue_init(&conn->secondary_list);
> 
> --
> 2.28.0
> 
> 



  reply	other threads:[~2020-09-23  1:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  9:55 [PATCH 0/3] colo-compare: minor fixes Li Zhijian
2020-09-22  9:55 ` [PATCH 1/3] colo-compare: return -1 if no packet is queued Li Zhijian
2020-09-23  1:41   ` Zhang, Chen
2020-09-23  6:17     ` Li Zhijian
2020-09-23  6:51       ` Zhang, Chen
2020-09-22  9:55 ` [PATCH 2/3] colo-compare: fix missing compare_seq initialization Li Zhijian
2020-09-23  1:42   ` Zhang, Chen [this message]
2020-09-22  9:55 ` [PATCH 3/3] colo-compare: check mark in mutual exclusion Li Zhijian
2020-09-23  1:46   ` Zhang, Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98329b97e8947d7a4b0d4c941fbb20e@intel.com \
    --to=chen.zhang@intel.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).