Re: [Qemu-devel] OpenRISC - SPR_PICMR always 'OR-ing' the values

[Davidson Francis <davidsondfgl@gmail.com>]

Hello,

Thanks for working on this, your tree works fine here and the issue
seems to be fixed, I have nothing to complain about.

Regards,
Davidson Francis.

On 01-07-2018 05:18, Stafford Horne wrote:
> Hello,
> 
> We have been working on a few patches to fixed QEMU for OpenRISC and I
> included the change for picmr writes, richard added some changes to
> SPR writes which might help with the masking/umasking work more
> reliably.
> 
> If you want to try them out could you check:
>     https://github.com/stffrdhrn/qemu/tree/or1k-fixes-212-1
> 
> Thanks for your help.
> 
> -Stafford
> 
> On Sun, May 20, 2018 at 12:32 PM Davidson Francis
> <davidsondfgl@gmail.com> wrote:
>>
>> Thank you for quick reply,
>>
>> Yes, I've tried, after that, the register works as expected, but even so, if I
>> enable the interrupts right after, I still receive interrupts from the same IRQ,
>> but maybe there is something wrong with my code.
>>
>> Regards,
>> Davidson Francis.
>>
>> 2018-05-19 23:54 GMT-03:00 Stafford Horne <shorne@gmail.com>:
>>> On Sat, May 19, 2018 at 08:08:47PM -0300, Davidson Francis wrote:
>>>> Hello Stafford,
>>>>
>>>> I'm currently using or1k as a target CPU in an operating system that
>>>> I'm working.
>>>> It happens that I'm having some issues regarding the PICMR register: I realize
>>>> that in the latest Qemu version (2.12) when I write into PICMR, the Qemu is
>>>> actually 'OR-ing' the values (as I could note in target/openrisc/sys_helper.c
>>>> file), so I can't mask an already enabled interrupt.
>>>>
>>>> I don't know if this behaviour is expected and if so, I'm sorry, but this does
>>>> not occurs in the or1ksim, so I thought this could be might an issue.
>>>
>>> Hello, thanks for pointing this out.  It looks wrong to me too.  Have you tested
>>> changing it to just `env->picmr = rb;`?
>>>
>>> -Stafford