qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [PATCH] hw/elf_ops: Fix a typo
Date: Tue, 9 Mar 2021 21:28:09 +0100	[thread overview]
Message-ID: <e9a2eaa7-1689-41a2-c69f-ee616b7af00e@vivier.eu> (raw)
In-Reply-To: <20210225181344.3623720-1-philmd@redhat.com>

Le 25/02/2021 à 19:13, Philippe Mathieu-Daudé a écrit :
> g_mapped_file_new_from_fd()'s parameter is named 'writable'.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  include/hw/elf_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
> index 8e8436831d2..304f266bf3b 100644
> --- a/include/hw/elf_ops.h
> +++ b/include/hw/elf_ops.h
> @@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>  
>      /*
>       * Since we want to be able to modify the mapped buffer, we set the
> -     * 'writeble' parameter to 'true'. Modifications to the buffer are not
> +     * 'writable' parameter to 'true'. Modifications to the buffer are not
>       * written back to the file.
>       */
>      mapped_file = g_mapped_file_new_from_fd(fd, true, NULL);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent



      parent reply	other threads:[~2021-03-09 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 18:13 [PATCH] hw/elf_ops: Fix a typo Philippe Mathieu-Daudé
2021-02-25 21:39 ` Stefano Garzarella
2021-03-03  8:18 ` David Edmondson
2021-03-09 20:28 ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a2eaa7-1689-41a2-c69f-ee616b7af00e@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).