From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node
Date: Tue, 30 Apr 2024 10:56:12 +0200 [thread overview]
Message-ID: <e9a82607-eb2f-44bb-b43e-bda2d8c42157@linaro.org> (raw)
In-Reply-To: <5535d6a6-4f6c-44d1-b1c7-b48672efa785@redhat.com>
On 30/4/24 10:22, Thomas Huth wrote:
> On 30/04/2024 10.19, David Hildenbrand wrote:
>> On 30.04.24 10:04, Thomas Huth wrote:
>>> The sclpconsole currently does not have a proper parent in the QOM
>>> tree, so it shows up under /machine/unattached - which is somewhat
>>> ugly. Let's attach it to /machine/sclp instead.
>>
>> IIRC, this should not affect migration
>
>
> Yes, that's my understanding, too. I also did a quick check from one
> QEMU without this patch to a QEMU that includes this patch, and
> migration just succeeded fine.
Indeed, QOM path isn't used in migration streams.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Thanks!
>
> Thomas
>
>
next prev parent reply other threads:[~2024-04-30 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 8:04 [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node Thomas Huth
2024-04-30 8:19 ` David Hildenbrand
2024-04-30 8:22 ` Thomas Huth
2024-04-30 8:56 ` Philippe Mathieu-Daudé [this message]
2024-04-30 11:58 ` Cédric Le Goater
2024-04-30 14:24 ` Thomas Huth
2024-04-30 19:06 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a82607-eb2f-44bb-b43e-bda2d8c42157@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).