From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH v5 3/3] target/mips: Enable MSA ASE using a CLI flag
Date: Wed, 26 Feb 2025 09:16:57 -0800 [thread overview]
Message-ID: <e9bf0606-c031-4e4e-89d9-a65a9f6171a4@linaro.org> (raw)
In-Reply-To: <20250226170246.1971355-5-aleksandar.rakic@htecgroup.com>
On 2/26/25 09:03, Aleksandar Rakic wrote:
> --- a/target/mips/internal.h
> +++ b/target/mips/internal.h
> @@ -399,7 +399,7 @@ static inline void compute_hflags(CPUMIPSState *env)
> }
> }
> if (ase_msa_available(env)) {
> - if (env->CP0_Config5 & (1 << CP0C5_MSAEn)) {
> + if ((env->CP0_Config5 & (1 << CP0C5_MSAEn)) || (env->msa_on)) {
> env->hflags |= MIPS_HFLAG_MSA;
> }
> }
This is the wrong place to force-enable msa.
You should be enabling the bit in Config5 during cpu realize.
r~
prev parent reply other threads:[~2025-02-26 17:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 17:02 [PATCH v5 0/3] Improve Mips target Aleksandar Rakic
2025-02-26 17:03 ` Aleksandar Rakic
2025-02-26 17:03 ` [PATCH v5 2/3] Skip NaN mode check for soft-float Aleksandar Rakic
2025-03-12 14:29 ` Aleksandar Rakic
2025-03-12 15:05 ` Peter Maydell
2025-03-18 11:31 ` Aleksandar Rakic
2025-03-18 11:35 ` Peter Maydell
2025-03-18 13:00 ` Aleksandar Rakic
2025-03-18 13:08 ` Peter Maydell
2025-03-18 13:18 ` Aleksandar Rakic
2025-02-26 17:03 ` [PATCH v5 1/3] Add support for emulation of CRC32 instructions Aleksandar Rakic
2025-03-12 14:26 ` Aleksandar Rakic
2025-03-18 13:45 ` Aleksandar Rakic
2025-03-26 12:31 ` Aleksandar Rakic
2025-04-23 12:57 ` Aleksandar Rakic
2025-05-14 14:10 ` Aleksandar Rakic
2025-05-19 12:24 ` Aleksandar Rikalo
2025-06-24 8:08 ` Aleksandar Rakic
2025-06-24 9:18 ` Daniel P. Berrangé
2025-02-26 17:03 ` [PATCH v5 3/3] target/mips: Enable MSA ASE using a CLI flag Aleksandar Rakic
2025-02-26 17:16 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9bf0606-c031-4e4e-89d9-a65a9f6171a4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).