From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F28C433DB for ; Thu, 11 Mar 2021 17:15:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F86464FE2 for ; Thu, 11 Mar 2021 17:15:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F86464FE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKOuG-0002iB-Vy for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 12:15:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKOrN-0000BB-7e for qemu-devel@nongnu.org; Thu, 11 Mar 2021 12:12:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKOrL-0006E7-Je for qemu-devel@nongnu.org; Thu, 11 Mar 2021 12:12:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615482746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5DNd4pQwLscAxhVOhJEI42KVwUZ/iwQdR4p74FfjrQQ=; b=HY+Mq2W0ZzFMhi/CyUz+mqtoDajMaF+PhO5z1PNVc49d6Oq3lM6RQgOCO/nSIkeTIShtv8 Z9B7upR3ZVXE5Lr/KrZpSeX7UWEF21zaO+nUinSKSGJodJTvoXtjSg0Mpc2zTeDRIFhqgl 7j2oyk5whQgY6jxYICmqWsQJF5BMm1U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-437-w3K98tGqMoCoW_4SA0PWUg-1; Thu, 11 Mar 2021 12:12:21 -0500 X-MC-Unique: w3K98tGqMoCoW_4SA0PWUg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B40E9A0CBF; Thu, 11 Mar 2021 17:12:20 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8EBE1101F961; Thu, 11 Mar 2021 17:12:19 +0000 (UTC) To: Richard Henderson , qemu-devel@nongnu.org References: <20210311161747.129834-1-david@redhat.com> <20210311161747.129834-2-david@redhat.com> <594f6840-2dad-89a2-9103-098e5f465ed4@linaro.org> From: David Hildenbrand Organization: Red Hat GmbH Subject: Re: [PATCH v5 1/2] target/s390x: Implement the MVPG condition-code-option bit Message-ID: Date: Thu, 11 Mar 2021 18:12:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <594f6840-2dad-89a2-9103-098e5f465ed4@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , Thomas Huth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11.03.21 18:02, Richard Henderson wrote: > On 3/11/21 10:17 AM, David Hildenbrand wrote: >> +#if !defined(CONFIG_USER_ONLY) >> + if (env->tlb_fill_exc) { >> + return env->tlb_fill_exc; >> + } >> +#else >> + if (!haddr1) { >> + env->__excp_addr = vaddr1; >> + return PGM_ADDRESSING; >> + } >> +#endif > > For user-only, we can rely on TLB_INVALID_MASK, and check once for both pages. Then, I cannot set the proper vaddr1 vs. vaddr2 (see patch #2). >> @@ -858,13 +925,26 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, uint64_t r1, uint64_t r2) >> /* >> * TODO: >> * - Access key handling >> - * - CC-option with surpression of page-translation exceptions >> * - Store r1/r2 register identifiers at real location 162 >> */ >> - srca = access_prepare(env, r2, TARGET_PAGE_SIZE, MMU_DATA_LOAD, mmu_idx, >> - ra); >> - desta = access_prepare(env, r1, TARGET_PAGE_SIZE, MMU_DATA_STORE, mmu_idx, >> - ra); >> + exc = access_prepare_nf(&srca, env, cco, r2, TARGET_PAGE_SIZE, >> + MMU_DATA_LOAD, mmu_idx, ra); >> + if (exc) { >> + return 2; >> + } >> + exc = access_prepare_nf(&desta, env, cco, r1, TARGET_PAGE_SIZE, >> + MMU_DATA_STORE, mmu_idx, ra); >> + if (exc) { >> +#if !defined(CONFIG_USER_ONLY) >> + if (exc == PGM_PROTECTION) { >> + stq_phys(env_cpu(env)->as, >> + env->psa + offsetof(LowCore, trans_exc_code), >> + env->tlb_fill_tec); >> + tcg_s390_program_interrupt(env, PGM_PROTECTION, ra); >> + } >> +#endif >> + return 1; >> + } >> access_memmove(env, &desta, &srca, ra); >> return 0; /* data moved */ >> } > > If we're going to have an ifdef at all here, it should be around the entire > helper -- this is a privileged operation. Privileged operation (access key specified, and selected PSW-key-mask bit is zero in the prob- lem state) Without an access key in GR0, we're using the PSW key - which should always work, no? What am I missing? -- Thanks, David / dhildenb