Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

[Leonardo Bras <leonardo@linux.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

Hello Bharata, thank you for reviewing and testing!

During review of this new flag, it was suggested to change it's name to
a better one (on platform's viewpoint). 

So I will have to change the flag name from SPAPR_LMB_FLAGS_HOTPLUGGED
to SPAPR_LMB_FLAGS_HOTREMOVABLE.

Everything should work the same as today.

Best regards,
Leonardo



On Thu, 2020-04-02 at 14:46 +0530, Bharata B Rao wrote:
> On Tue, Mar 10, 2020 at 8:24 AM David Gibson
> <david@gibson.dropbear.id.au> wrote:
> > On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote:
> > > On reboot, all memory that was previously added using object_add and
> > > device_add is placed in this DIMM area.
> > > 
> > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in
> > > the correct memory zone, so no unmovable allocations are made there,
> > > allowing the object to be easily hot-removed by device_del and
> > > object_del.
> > > 
> > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> > > 
> > > ---
> > > The new flag was already proposed on Power Architecture documentation,
> > > and it's waiting for approval.
> > > 
> > > I would like to get your comments on this change, but it's still not
> > > ready for being merged.
> > 
> > This looks reasonable to me - at the very least it doesn't look like
> > it could do much harm.
> 
> Looks good to me, also tested with PowerKVM guests.
> 
> Reviewed-by: Bharata B Rao <bharata@linux.ibm.com>
> 
> Regards,
> Bharata.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]