From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43E41E77199 for ; Wed, 8 Jan 2025 14:16:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVWq4-00063L-Qi; Wed, 08 Jan 2025 09:15:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVWq3-00062C-4u for qemu-devel@nongnu.org; Wed, 08 Jan 2025 09:15:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVWq0-0004zQ-Ft for qemu-devel@nongnu.org; Wed, 08 Jan 2025 09:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736345709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6xKFvF+CTfc/Sx73gmcJGcAlmt1nugJqIuC/683n58I=; b=EkTAlTYKCrHBlYzBL+zhVDegjXeOx9AyW+wHSAsAfL7LTHvmGJkKzQQtyS+ajV+gUpouCs YaJHA6pfjxYnMIQQBNxsuketu/6CaSiWXUhyg83y21UhIYG3KLz8lnKK01g4SgiphFHky0 naPVo6Tk/T1NHvGB5rtoMzXJCvSKTJQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-F7nh-ZajOG2Fp9tA42u9wQ-1; Wed, 08 Jan 2025 09:15:08 -0500 X-MC-Unique: F7nh-ZajOG2Fp9tA42u9wQ-1 X-Mimecast-MFC-AGG-ID: F7nh-ZajOG2Fp9tA42u9wQ Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6d92f0737beso236819596d6.1 for ; Wed, 08 Jan 2025 06:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736345707; x=1736950507; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6xKFvF+CTfc/Sx73gmcJGcAlmt1nugJqIuC/683n58I=; b=YztlMzSyIVDHzsffJNCH5dVz+oFCzQiayCMKJpHYXp3T8zQoOEuenr63v8xFiU46Ad CqzvU/Ra1nkwd3KdY8WoMGO5zfWNgBI2U+uYVXaxk4Dv2CRqV0SUYy+flHL1J/vxK7CV Dfd45LqKpGG4U1+kPnviZilmxTjAZKLu/tzuGKMmwEaT9NUGd92TXNJT7ThJ1Z7GByJE mmklI96b1bIz89WDxCagxm6q3bgqvM2piYRVUD08JA0hXPCp9IN7xW3BueIr/1d5Vn/e Ta3VL9gA78vTSDNG2DfpMHBgUA6W8rBz1wtiXkx2qnq3fjijYRZJHXnofaLpsXH6F8Vv f5Ng== X-Forwarded-Encrypted: i=1; AJvYcCXMv2jiswqFmzAhJMYhze9vUWRwXwvikYSbK6uMoSlnsvb/Ic7/4eUwJ1FmKcwQdLXklR2Ycvp3VW5t@nongnu.org X-Gm-Message-State: AOJu0YxwJgmV6qdV/2XBkXDcl/EETaXRbc/qBh5qinIz1TjHrxTEgMwp dqYxD+qmt78Cl5xI4vpHXDkUQd8NzVojGe4leeE0PIw/8di3TkKsbx4rrQNS+3uctUKc5twg+FB 0G4ed5mMUof2d1BcH/ypY3b2cNwhCxa4Viza6tt6i+27lbAl06c8E X-Gm-Gg: ASbGncthwxER1ENcfsgRdzzE6tO1+b/PSsKkhSiW8MQSsXQBXAj+PlTTlWPQ28mNJqY 39Mfp8z6amBiPXY1RZq7HhixGQD7OEAMIpJeajGIMv19pmFZuYdcUONCs5eiTZzN5UPvTkkpUi9 DXgJfC7BtYnPAp0GflCuEfebIkRye/miLAyeC39AcAI0zbHTNedvINQrTxtoJfPTqQTx4F6a3JI ML//ZaKZBZQqwlQobjwg/xYZQRdq2M6hXBXUBsTSmFxR+gFL9y+/rfLzsFFnCxS7DnvutyOp24X BC641A== X-Received: by 2002:ad4:5967:0:b0:6d8:8aa6:ef27 with SMTP id 6a1803df08f44-6df9b2d7f31mr51264326d6.38.1736345707516; Wed, 08 Jan 2025 06:15:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3i3rsX9px8lK3V6fS+YqRn1Jlw2pBrrzfYBTXOzgsCFyL3548rAfZc6ZYPfZlSLWNsU+9Lw== X-Received: by 2002:ad4:5967:0:b0:6d8:8aa6:ef27 with SMTP id 6a1803df08f44-6df9b2d7f31mr51263836d6.38.1736345707164; Wed, 08 Jan 2025 06:15:07 -0800 (PST) Received: from [10.33.192.228] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e6a9cb6sm196062931cf.51.2025.01.08.06.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 06:15:06 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 15:15:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/32] tests/functional: remove unused kernel_command_line To: =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: Halil Pasic , Aurelien Jarno , qemu-riscv@nongnu.org, Radoslaw Biernacki , Daniel Henrique Barboza , Marcel Apfelbaum , Richard Henderson , Beraldo Leal , Fabiano Rosas , Mark Cave-Ayland , Laurent Vivier , Nicholas Piggin , Marcin Juszkiewicz , Christian Borntraeger , Wainer dos Santos Moschetta , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Ed Maste , Jiaxun Yang , Bernhard Beschow , Bin Meng , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, Laurent Vivier , Joel Stanley , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , "Michael S. Tsirkin" , Pavel Dovgalyuk , Alistair Francis , Liu Zhiwei , Harsh Prateek Bora , Leif Lindholm , Cleber Rosa , Paolo Bonzini , qemu-s390x@nongnu.org, Eric Farman , Weiwei Li , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , Daniel Henrique Barboza , Palmer Dabbelt , Peter Maydell , Li-Wen Hsu References: <20250108121054.1126164-1-alex.bennee@linaro.org> <20250108121054.1126164-22-alex.bennee@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250108121054.1126164-22-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.432, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 08/01/2025 13.10, Alex Bennée wrote: > The Alpine test boots from the CDROM so we don't --append a command > line. Drop the unused code. > > Signed-off-by: Alex Bennée > --- > tests/functional/test_aarch64_virt.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional/test_aarch64_virt.py > index 2d9995a95d..b3d3b0ee51 100755 > --- a/tests/functional/test_aarch64_virt.py > +++ b/tests/functional/test_aarch64_virt.py > @@ -41,8 +41,6 @@ def test_alpine_virt_tcg_gic_max(self): > > self.set_machine('virt') > self.vm.set_console() > - kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > - 'console=ttyAMA0') > self.require_accelerator("tcg") > > self.vm.add_args("-accel", "tcg") Reviewed-by: Thomas Huth