From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 02/10] linux-user: Fix parse_elf_properties GNU0_MAGIC check
Date: Mon, 7 Oct 2024 16:50:15 -0300 [thread overview]
Message-ID: <e9ed68d9-1cdc-4b6c-a644-1c8cfce6eb01@linaro.org> (raw)
In-Reply-To: <20241005233343.503426-3-richard.henderson@linaro.org>
On 5/10/24 20:33, Richard Henderson wrote:
> Comparing a string of 4 bytes only works in little-endian.
>
> Adjust bulk bswap to only apply to the note payload.
> Perform swapping of the note header manually; the magic
> is defined so that it does not need a runtime swap.
>
> Fixes: 83f990eb5adb ("linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2596
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/elfload.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-10-07 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 23:33 [PATCH 00/10] linux-user pre-PR Richard Henderson
2024-10-05 23:33 ` [PATCH 01/10] linux-user/flatload: Take mmap_lock in load_flt_binary() Richard Henderson
2024-10-05 23:33 ` [PATCH 02/10] linux-user: Fix parse_elf_properties GNU0_MAGIC check Richard Henderson
2024-10-07 19:50 ` Philippe Mathieu-Daudé [this message]
2024-10-05 23:33 ` [PATCH 03/10] linux-user: add openat2 support in linux-user Richard Henderson
2024-10-05 23:33 ` [PATCH 04/10] linux-user: add strace support for openat2 Richard Henderson
2024-10-05 23:33 ` [PATCH 05/10] linux-user: Trace wait4()'s and waitpid()'s wstatus Richard Henderson
2024-10-05 23:33 ` [PATCH 06/10] linux-user: Correct print_sockaddr() format Richard Henderson
2024-10-07 19:50 ` Philippe Mathieu-Daudé
2024-10-05 23:33 ` [PATCH 07/10] linux-user: Display sockaddr buffer as pointer Richard Henderson
2024-10-05 23:33 ` [PATCH 08/10] linux-user: Factor print_buf_len() out Richard Henderson
2024-10-05 23:33 ` [PATCH 09/10] linux-user: Add strace for sendto() Richard Henderson
2024-10-05 23:33 ` [PATCH 10/10] linux-user: Add strace for recvfrom() Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9ed68d9-1cdc-4b6c-a644-1c8cfce6eb01@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).