From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: thuth@redhat.com, kvm@vger.kernel.org, pmorel@linux.ibm.com,
david@redhat.com, schnelle@linux.ibm.com, qemu-s390x@nongnu.org,
qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, alex.williamson@redhat.com,
mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x
Date: Tue, 6 Oct 2020 12:43:39 -0400 [thread overview]
Message-ID: <e9f6c3e1-9341-b0d0-9fb2-b34ebd19bcba@linux.ibm.com> (raw)
In-Reply-To: <20201006173259.1ec36597.cohuck@redhat.com>
On 10/6/20 11:32 AM, Cornelia Huck wrote:
> On Fri, 2 Oct 2020 16:06:23 -0400
> Matthew Rosato <mjrosato@linux.ibm.com> wrote:
>
>> Seems a more appropriate location for them.
>>
>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>> ---
>> hw/s390x/s390-pci-bus.c | 4 +-
>> hw/s390x/s390-pci-bus.h | 372 ---------------------------------------
>> hw/s390x/s390-pci-inst.c | 4 +-
>> hw/s390x/s390-pci-inst.h | 312 --------------------------------
>> hw/s390x/s390-virtio-ccw.c | 2 +-
>> include/hw/s390x/s390-pci-bus.h | 372 +++++++++++++++++++++++++++++++++++++++
>> include/hw/s390x/s390-pci-inst.h | 312 ++++++++++++++++++++++++++++++++
>> 7 files changed, 689 insertions(+), 689 deletions(-)
>> delete mode 100644 hw/s390x/s390-pci-bus.h
>> delete mode 100644 hw/s390x/s390-pci-inst.h
>> create mode 100644 include/hw/s390x/s390-pci-bus.h
>> create mode 100644 include/hw/s390x/s390-pci-inst.h
>
> Looks good, but...
>
> <meta>Is there any way to coax out a more reviewable version of this
> via git mv?</meta>
>
I tried git mv, but a diff between the old patch and the new patch looks
the same (other than the fact that I squashed the MAINTAINERS hit in)
next prev parent reply other threads:[~2020-10-06 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 20:06 [PATCH v2 0/9] Retrieve zPCI hardware information from VFIO Matthew Rosato
2020-10-02 20:06 ` [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x Matthew Rosato
2020-10-06 15:32 ` Cornelia Huck
2020-10-06 16:43 ` Matthew Rosato [this message]
2020-10-06 17:33 ` Richard Henderson
2020-10-06 17:38 ` Matthew Rosato
2020-10-07 7:35 ` Paolo Bonzini
2020-10-02 20:06 ` [PATCH v2 2/9] MAINTAINERS: Update s390 PCI entry to include headers Matthew Rosato
2020-10-06 15:34 ` Cornelia Huck
2020-10-02 20:06 ` [PATCH v2 3/9] update-linux-headers: Add vfio_zdev.h Matthew Rosato
2020-10-06 15:36 ` Cornelia Huck
2020-10-02 20:06 ` [PATCH v2 4/9] linux-headers: update against 5.9-rc7 Matthew Rosato
2020-10-06 15:39 ` Cornelia Huck
2020-10-06 15:46 ` Matthew Rosato
2020-10-02 20:06 ` [PATCH v2 5/9] s390x/pci: create a header dedicated to PCI CLP Matthew Rosato
2020-10-06 15:42 ` Cornelia Huck
2020-10-02 20:06 ` [PATCH v2 6/9] s390x/pci: use a PCI Group structure Matthew Rosato
2020-10-02 20:06 ` [PATCH v2 7/9] s390x/pci: clean up s390 PCI groups Matthew Rosato
2020-10-02 20:06 ` [PATCH v2 8/9] s390x/pci: use a PCI Function structure Matthew Rosato
2020-10-02 20:06 ` [PATCH v2 9/9] s390x/pci: get zPCI function info from host Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f6c3e1-9341-b0d0-9fb2-b34ebd19bcba@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=schnelle@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).