From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Matheus Tavares Bernardino" <quic_mathbern@quicinc.com>
Subject: Re: [PATCH 7/8] gdbstub: more fixes for client Ctrl-C handling
Date: Thu, 10 Aug 2023 09:26:46 -0700 [thread overview]
Message-ID: <ea1034db-68b6-8644-7fc0-309596ede0e1@linaro.org> (raw)
In-Reply-To: <20230810153640.1879717-8-alex.bennee@linaro.org>
On 8/10/23 08:36, Alex Bennée wrote:
> The original fix caused problems with spurious characters on other
> system emulation. So:
>
> - instead of spamming output make the warning a trace point
> - ensure we only allow a stop reply if it was 0x3
>
> Suggested-by: Matheus Tavares Bernardino<quic_mathbern@quicinc.com>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Message-Id:<456ed3318421dd7946bdfb5ceda7e05332da368c.1690910333.git.quic_mathbern@quicinc.com>
> ---
> gdbstub/gdbstub.c | 5 +++--
> gdbstub/trace-events | 1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-08-10 16:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 15:36 [PATCH 0/8] some testing and gdbstub fixes Alex Bennée
2023-08-10 15:36 ` [PATCH 1/8] gitlab: enable ccache for many build jobs Alex Bennée
2023-08-10 15:36 ` [PATCH 2/8] tests/docker: cleanup non-verbose output Alex Bennée
2023-08-14 7:59 ` Thomas Huth
2023-08-10 15:36 ` [PATCH 3/8] tests/tcg: remove quoting for info output Alex Bennée
2023-08-10 15:36 ` [PATCH 4/8] tests: remove test-gdbstub.py Alex Bennée
2023-08-10 17:10 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 5/8] tests/tcg: clean-up gdb confirm/pagination settings Alex Bennée
2023-08-10 15:47 ` Philippe Mathieu-Daudé
2023-08-10 17:08 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped Alex Bennée
2023-08-10 15:48 ` Philippe Mathieu-Daudé
2023-08-10 17:08 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 7/8] gdbstub: more fixes for client Ctrl-C handling Alex Bennée
2023-08-10 15:56 ` Philippe Mathieu-Daudé
2023-08-10 16:26 ` Richard Henderson [this message]
2023-08-10 15:36 ` [PATCH 8/8] gdbstub: don't complain about preemptive ACK chars Alex Bennée
2023-08-10 15:50 ` Philippe Mathieu-Daudé
2023-08-10 15:58 ` [PATCH 0/8] some testing and gdbstub fixes Peter Maydell
2023-08-10 16:35 ` Alex Bennée
2023-08-10 16:43 ` Richard Henderson
2023-08-10 17:33 ` Richard Henderson
2023-08-10 16:35 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea1034db-68b6-8644-7fc0-309596ede0e1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).