From: Eric Blake <eblake@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
Stefan Weil <sw@weilnetz.de>,
QEMU Developer <qemu-devel@nongnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell
Date: Wed, 2 Nov 2016 08:29:26 -0500 [thread overview]
Message-ID: <ea7009c1-75d9-a7ea-641d-399d3b9c6689@redhat.com> (raw)
In-Reply-To: <fa396830-84d2-734a-c51a-7d3073b10183@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
On 11/01/2016 08:32 PM, Zhang Chen wrote:
>>> I still don't understand the comment in docs/colo-proxy.txt.
>> Me neither.
>>
>>
>
> Which part of the docs/colo-proxy.txt?
The one quoted below.
> Perhaps I can explain it more clearly and make the doc better.
>
>>> +++ b/docs/colo-proxy.txt
>>> @@ -158,7 +158,7 @@ secondary.
>>> == Usage ==
>>> -Here, we use demo ip and port discribe more clearly.
>>> +Here, we use demo ip and port describe more clearly.
>>> Primary(ip:3.3.3.3):
>>> -netdev
>>> tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
>>> -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
>> Maybe:
>>
>> Here is an example using demonstration IP and port addresses to more
>> clearly describe the usage.
>>
>> The remaining hunks are clear improvements, so:
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> It's easier to understand.
Okay, so you like my proposal for a potential reword. Now, who should
submit it as a patch? Stefan (since he found the confusing sentence in
the first place), you (since you wrote most of the document to begin
with), or me (since I proposed wording that you like)?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-11-02 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:19 [Qemu-devel] [PATCH] docs: Fix typos found by codespell Stefan Weil
2016-11-01 17:32 ` Peter Maydell
2016-11-01 17:52 ` Eric Blake
2016-11-02 1:32 ` Zhang Chen
2016-11-02 13:29 ` Eric Blake [this message]
2016-11-03 1:44 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7009c1-75d9-a7ea-641d-399d3b9c6689@redhat.com \
--to=eblake@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).