From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1vbg-0006N7-M2 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 09:29:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1vbd-0006IY-I4 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 09:29:32 -0400 References: <20161101171927.25684-1-sw@weilnetz.de> From: Eric Blake Message-ID: Date: Wed, 2 Nov 2016 08:29:26 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BCxNw7NPA0MVJiAO4AU7tXll4wgkHhHVT" Subject: Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , Stefan Weil , QEMU Developer Cc: QEMU Trivial , Li Zhijian , zhanghailiang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BCxNw7NPA0MVJiAO4AU7tXll4wgkHhHVT From: Eric Blake To: Zhang Chen , Stefan Weil , QEMU Developer Cc: QEMU Trivial , Li Zhijian , zhanghailiang Message-ID: Subject: Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell References: <20161101171927.25684-1-sw@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/01/2016 08:32 PM, Zhang Chen wrote: >>> I still don't understand the comment in docs/colo-proxy.txt. >> Me neither. >> >> >=20 > Which part of the docs/colo-proxy.txt? The one quoted below. > Perhaps I can explain it more clearly and make the doc better. >=20 >>> +++ b/docs/colo-proxy.txt >>> @@ -158,7 +158,7 @@ secondary. >>> =3D=3D Usage =3D=3D >>> -Here, we use demo ip and port discribe more clearly. >>> +Here, we use demo ip and port describe more clearly. >>> Primary(ip:3.3.3.3): >>> -netdev >>> tap,id=3Dhn0,vhost=3Doff,script=3D/etc/qemu-ifup,downscript=3D/etc/qe= mu-ifdown >>> -device e1000,id=3De0,netdev=3Dhn0,mac=3D52:a4:00:12:78:66 >> Maybe: >> >> Here is an example using demonstration IP and port addresses to more >> clearly describe the usage. >> >> The remaining hunks are clear improvements, so: >> Reviewed-by: Eric Blake >=20 > It's easier to understand. Okay, so you like my proposal for a potential reword. Now, who should submit it as a patch? Stefan (since he found the confusing sentence in the first place), you (since you wrote most of the document to begin with), or me (since I proposed wording that you like)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BCxNw7NPA0MVJiAO4AU7tXll4wgkHhHVT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYGeo2AAoJEKeha0olJ0NqZl4H/3EYbWUJDYKuj+5qUsc23pzj 9mzQyk5ZZKxCy4zbyBHkKx09zyGbjAEoyxjf+YgaIBNFUlF8jDyYdb4KZA0xuisM 6MgZIBVEOMst2Ruy8Bvjaqcep5dPD63SaBheC6ZbyarSO1lSnfKdzYEbjFZNMBpx qQFt9I63y0eX2G2Z5EE3mA+/Wfuswgj4+cWLlpt2D+Z9r66wsAG8WcyP7+j7uXmM qqtp+skXu6tZ52TTetx5HlkZvNOS4MoWn84vfEMCqA3CbP9/ZaWJ9SJcDyFfJbI1 z3DzYEhh9L9s2EDGCqNa8YHmZwYGUP/24e3uBCXvkDDymaYWixLDVv2PCeEbkE4= =Js3j -----END PGP SIGNATURE----- --BCxNw7NPA0MVJiAO4AU7tXll4wgkHhHVT--