From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>, qemu-devel@nongnu.org
Cc: minwoo.im@samsung.com, alex.williamson@redhat.com,
clg@redhat.com, chao.p.peng@intel.com
Subject: Re: [PATCH v2] vfio/pci: Fix a use-after-free issue
Date: Wed, 24 May 2023 08:08:20 +0200 [thread overview]
Message-ID: <ea8591a0-dd70-8c9a-9c49-f23ef270546f@linaro.org> (raw)
In-Reply-To: <20230517024651.82248-1-zhenzhong.duan@intel.com>
On 17/5/23 04:46, Zhenzhong Duan wrote:
> vbasedev->name is freed wrongly which leads to garbage VFIO trace log.
> Fix it by allocating a dup of vbasedev->name and then free the dup.
>
> Fixes: 2dca1b37a7 ("vfio/pci: add support for VF token")
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
> v2: "toke" -> "token", Cedric
> Update with Alex suggested change
>
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-05-24 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 2:46 [PATCH v2] vfio/pci: Fix a use-after-free issue Zhenzhong Duan
2023-05-17 6:11 ` Cédric Le Goater
2023-05-23 17:00 ` Matthew Rosato
2023-05-23 17:17 ` Alex Williamson
2023-05-23 17:52 ` Alex Williamson
2023-05-24 6:08 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8591a0-dd70-8c9a-9c49-f23ef270546f@linaro.org \
--to=philmd@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clg@redhat.com \
--cc=minwoo.im@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).