* [PATCH] gitlab: enable afalg tests in fedora system test
@ 2024-10-21 17:02 Daniel P. Berrangé
2024-10-22 4:24 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2024-10-21 17:02 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Wainer dos Santos Moschetta, Markus Armbruster,
Philippe Mathieu-Daudé, Cédric Le Goater, Thomas Huth,
Daniel P. Berrangé
The AF_ALG crypto integration for Linux is not being tested in
any CI scenario. It always requires an explicit configure time
flag to be passed to turn it on. The Fedora system test is
arbitrarily picked as the place to test it.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
.gitlab-ci.d/buildtest.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This is to detect the situation Markus found here:
https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 01e8470a69..f0cbdf1992 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -115,7 +115,7 @@ build-system-fedora:
job: amd64-fedora-container
variables:
IMAGE: fedora
- CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
+ CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
TARGETS: microblaze-softmmu mips-softmmu
xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
MAKE_CHECK_ARGS: check-build
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gitlab: enable afalg tests in fedora system test
2024-10-21 17:02 [PATCH] gitlab: enable afalg tests in fedora system test Daniel P. Berrangé
@ 2024-10-22 4:24 ` Philippe Mathieu-Daudé
2024-10-22 5:31 ` Thomas Huth
2024-10-22 16:26 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-22 4:24 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Alex Bennée, Wainer dos Santos Moschetta, Markus Armbruster,
Cédric Le Goater, Thomas Huth
On 21/10/24 14:02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/buildtest.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitlab: enable afalg tests in fedora system test
2024-10-21 17:02 [PATCH] gitlab: enable afalg tests in fedora system test Daniel P. Berrangé
2024-10-22 4:24 ` Philippe Mathieu-Daudé
@ 2024-10-22 5:31 ` Thomas Huth
2024-10-22 8:03 ` Daniel P. Berrangé
2024-10-22 16:26 ` Cédric Le Goater
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2024-10-22 5:31 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Alex Bennée, Wainer dos Santos Moschetta, Markus Armbruster,
Philippe Mathieu-Daudé, Cédric Le Goater, Longpeng
On 21/10/2024 19.02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/buildtest.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This is to detect the situation Markus found here:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
>
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index 01e8470a69..f0cbdf1992 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -115,7 +115,7 @@ build-system-fedora:
> job: amd64-fedora-container
> variables:
> IMAGE: fedora
> - CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> + CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
> TARGETS: microblaze-softmmu mips-softmmu
> xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
> MAKE_CHECK_ARGS: check-build
Is there a reason for this feature being disabled by default? Who is using
it if it is disabled by default? Should we maybe rather enable it by default
instead?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitlab: enable afalg tests in fedora system test
2024-10-22 5:31 ` Thomas Huth
@ 2024-10-22 8:03 ` Daniel P. Berrangé
2024-10-22 8:54 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrangé @ 2024-10-22 8:03 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Alex Bennée, Wainer dos Santos Moschetta,
Markus Armbruster, Philippe Mathieu-Daudé,
Cédric Le Goater, Longpeng
On Tue, Oct 22, 2024 at 07:31:49AM +0200, Thomas Huth wrote:
> On 21/10/2024 19.02, Daniel P. Berrangé wrote:
> > The AF_ALG crypto integration for Linux is not being tested in
> > any CI scenario. It always requires an explicit configure time
> > flag to be passed to turn it on. The Fedora system test is
> > arbitrarily picked as the place to test it.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > .gitlab-ci.d/buildtest.yml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This is to detect the situation Markus found here:
> >
> > https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
> >
> > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> > index 01e8470a69..f0cbdf1992 100644
> > --- a/.gitlab-ci.d/buildtest.yml
> > +++ b/.gitlab-ci.d/buildtest.yml
> > @@ -115,7 +115,7 @@ build-system-fedora:
> > job: amd64-fedora-container
> > variables:
> > IMAGE: fedora
> > - CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> > + CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
> > TARGETS: microblaze-softmmu mips-softmmu
> > xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
> > MAKE_CHECK_ARGS: check-build
>
> Is there a reason for this feature being disabled by default? Who is using
> it if it is disabled by default? Should we maybe rather enable it by default
> instead?
afalg isn't something you want to use in general. It performs worse than
the userspace crypto in many cases, especially for small buffers where the
context switch overhead kills.
It is potentially interesting if you have hardware crypto accelerator and
your guest workload also wants virtio-crypto.
Having it as a compile time option is not ideal, but it was the least
effort tradeoff.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitlab: enable afalg tests in fedora system test
2024-10-22 8:03 ` Daniel P. Berrangé
@ 2024-10-22 8:54 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2024-10-22 8:54 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: qemu-devel, Alex Bennée, Wainer dos Santos Moschetta,
Markus Armbruster, Philippe Mathieu-Daudé,
Cédric Le Goater, Longpeng
On 22/10/2024 10.03, Daniel P. Berrangé wrote:
> On Tue, Oct 22, 2024 at 07:31:49AM +0200, Thomas Huth wrote:
>> On 21/10/2024 19.02, Daniel P. Berrangé wrote:
>>> The AF_ALG crypto integration for Linux is not being tested in
>>> any CI scenario. It always requires an explicit configure time
>>> flag to be passed to turn it on. The Fedora system test is
>>> arbitrarily picked as the place to test it.
>>>
>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>> ---
>>> .gitlab-ci.d/buildtest.yml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> This is to detect the situation Markus found here:
>>>
>>> https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
>>>
>>> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
>>> index 01e8470a69..f0cbdf1992 100644
>>> --- a/.gitlab-ci.d/buildtest.yml
>>> +++ b/.gitlab-ci.d/buildtest.yml
>>> @@ -115,7 +115,7 @@ build-system-fedora:
>>> job: amd64-fedora-container
>>> variables:
>>> IMAGE: fedora
>>> - CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
>>> + CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
>>> TARGETS: microblaze-softmmu mips-softmmu
>>> xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
>>> MAKE_CHECK_ARGS: check-build
>>
>> Is there a reason for this feature being disabled by default? Who is using
>> it if it is disabled by default? Should we maybe rather enable it by default
>> instead?
>
> afalg isn't something you want to use in general. It performs worse than
> the userspace crypto in many cases, especially for small buffers where the
> context switch overhead kills.
>
> It is potentially interesting if you have hardware crypto accelerator and
> your guest workload also wants virtio-crypto.
>
> Having it as a compile time option is not ideal, but it was the least
> effort tradeoff.
Ok, makes sense, thanks for the explanation.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitlab: enable afalg tests in fedora system test
2024-10-21 17:02 [PATCH] gitlab: enable afalg tests in fedora system test Daniel P. Berrangé
2024-10-22 4:24 ` Philippe Mathieu-Daudé
2024-10-22 5:31 ` Thomas Huth
@ 2024-10-22 16:26 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2024-10-22 16:26 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Alex Bennée, Wainer dos Santos Moschetta, Markus Armbruster,
Philippe Mathieu-Daudé, Thomas Huth
On 10/21/24 19:02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> ---
> .gitlab-ci.d/buildtest.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This is to detect the situation Markus found here:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
>
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index 01e8470a69..f0cbdf1992 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -115,7 +115,7 @@ build-system-fedora:
> job: amd64-fedora-container
> variables:
> IMAGE: fedora
> - CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> + CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
> TARGETS: microblaze-softmmu mips-softmmu
> xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
> MAKE_CHECK_ARGS: check-build
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-22 16:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 17:02 [PATCH] gitlab: enable afalg tests in fedora system test Daniel P. Berrangé
2024-10-22 4:24 ` Philippe Mathieu-Daudé
2024-10-22 5:31 ` Thomas Huth
2024-10-22 8:03 ` Daniel P. Berrangé
2024-10-22 8:54 ` Thomas Huth
2024-10-22 16:26 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).