From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C39DCC433E0 for ; Sat, 27 Feb 2021 18:54:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9E664E33 for ; Sat, 27 Feb 2021 18:54:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9E664E33 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lG4jC-0004VC-3I for qemu-devel@archiver.kernel.org; Sat, 27 Feb 2021 13:54:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG4hs-0003PF-5J; Sat, 27 Feb 2021 13:52:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:47374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG4hm-0008T1-3g; Sat, 27 Feb 2021 13:52:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 54D85AC24; Sat, 27 Feb 2021 18:52:39 +0000 (UTC) Subject: Re: [PATCH 07/16] cpu: Introduce CPUSystemOperations structure To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210226163227.4097950-1-f4bug@amsat.org> <20210226163227.4097950-8-f4bug@amsat.org> From: Claudio Fontana Message-ID: Date: Sat, 27 Feb 2021 19:52:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210226163227.4097950-8-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.35, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Chris Wulff , Sagar Karandikar , David Hildenbrand , Anthony Green , Mark Cave-Ayland , Thomas Huth , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Yoshinori Sato , "Michael S. Tsirkin" , Palmer Dabbelt , Artyom Tarasenko , Aleksandar Rikalo , Eduardo Habkost , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/26/21 5:32 PM, Philippe Mathieu-Daudé wrote: > Introduce a structure to hold handler specific to sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > index b12028c3c03..ab89235cb45 100644 > --- a/include/hw/core/cpu.h > +++ b/include/hw/core/cpu.h > @@ -80,6 +80,12 @@ struct TCGCPUOps; > /* see accel-cpu.h */ > struct AccelCPUClass; > > +/* > + * struct CPUSystemOperations: System operations specific to a CPU class > + */ > +typedef struct CPUSystemOperations { > +} CPUSystemOperations; > + > /** > * CPUClass: > * @class_by_name: Callback to map -cpu command line model name to an > @@ -190,6 +196,9 @@ struct CPUClass { > bool gdb_stop_before_watchpoint; > struct AccelCPUClass *accel_cpu; > > + /* when system emulation is not available, this pointer is NULL */ > + struct CPUSystemOperations system_ops; and here again for future code base consistency I would say "sysemu_ops". So we will focus in the future on the "sysemu" keyword for system emulation (in directories, comments, macros etc). Ciao, Claudio > + > /* when TCG is not available, this pointer is NULL */ > struct TCGCPUOps *tcg_ops; > }; >